Upgrade build targets to ES2021 #3775

justinfagnani · 2023-03-31T00:38:55Z

I did this across the board: TypeScript target and lib, and Terser ecma setting, for all packages and tools tsconfigs. This might be a bit aggressive, but I want to see if this works.

changeset-bot · 2023-03-31T00:38:58Z

⚠️ No Changeset found

Latest commit: 4ef10ca

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2023-03-31T00:39:17Z

📊 Tachometer Benchmark Results

Summary

nop-update

lit-html-kitchen-sink: slower ❌ 1% - 9% (0.18ms - 1.69ms)
^{this-change vs tip-of-tree}

render

lit-element-list: 89.82ms - 95.11ms
lit-html-kitchen-sink: unsure 🔍 -6% - +6% (-2.43ms - +2.47ms)
^{this-change vs tip-of-tree}
lit-html-repeat: unsure 🔍 -7% - +1% (-0.91ms - +0.08ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -4% - +2% (-2.78ms - +1.42ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -1% - +6% (-0.80ms - +3.51ms)
^{this-change vs tip-of-tree}

update

lit-element-list: 925.11ms - 938.98ms
lit-html-kitchen-sink: unsure 🔍 -6% - +2% (-5.70ms - +1.90ms)
^{this-change vs tip-of-tree}
lit-html-repeat: unsure 🔍 -1% - +4% (-4.15ms - +13.53ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -2% - +1% (-2.71ms - +2.03ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -1% - +1% (-6.06ms - +8.08ms)
^{this-change vs tip-of-tree}

update-reflect

lit-element-list: 892.80ms - 901.33ms
reactive-element-list: unsure 🔍 -1% - +1% (-6.37ms - +7.02ms)
^{this-change vs tip-of-tree}

Results

lit-element-list

Browser: chrome-headless 111.0.5563.146
Sample size: 50
Built by: Benchmarks #4638
Commit: 530f887

render

Version	Avg time	vs
	89.82ms - 95.11ms	-

update

Version	Avg time	vs
	925.11ms - 938.98ms	-

update-reflect

Version	Avg time	vs
	892.80ms - 901.33ms	-

lit-html-kitchen-sink

Browser: chrome-headless 111.0.5563.146
Sample size: 30
Built by: Benchmarks #4638
Commit: 530f887

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	38.89ms - 42.70ms	-	unsure 🔍 -6% - +6% -2.43ms - +2.47ms	unsure 🔍 -4% - +9% -1.75ms - +3.71ms
tip-of-tree tip-of-tree	39.23ms - 42.31ms	unsure 🔍 -6% - +6% -2.47ms - +2.43ms	-	unsure 🔍 -4% - +9% -1.53ms - +3.45ms
previous-release previous-release	37.86ms - 41.77ms	unsure 🔍 -9% - +4% -3.71ms - +1.75ms	unsure 🔍 -8% - +4% -3.45ms - +1.53ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	92.98ms - 99.52ms	-	unsure 🔍 -6% - +2% -5.70ms - +1.90ms	unsure 🔍 -5% - +3% -5.11ms - +3.22ms
tip-of-tree tip-of-tree	96.21ms - 100.09ms	unsure 🔍 -2% - +6% -1.90ms - +5.70ms	-	unsure 🔍 -2% - +4% -2.27ms - +4.18ms
previous-release previous-release	94.61ms - 99.78ms	unsure 🔍 -3% - +5% -3.22ms - +5.11ms	unsure 🔍 -4% - +2% -4.18ms - +2.27ms	-

nop-update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	18.87ms - 20.33ms	-	slower ❌ 1% - 9% 0.18ms - 1.69ms	unsure 🔍 -2% - +8% -0.33ms - +1.44ms
tip-of-tree tip-of-tree	18.46ms - 18.88ms	faster ✔ 1% - 8% 0.18ms - 1.69ms	-	unsure 🔍 -5% - +1% -0.93ms - +0.17ms
previous-release previous-release	18.54ms - 19.55ms	unsure 🔍 -7% - +2% -1.44ms - +0.33ms	unsure 🔍 -1% - +5% -0.17ms - +0.93ms	-

lit-html-repeat

Browser: chrome-headless 111.0.5563.146
Sample size: 30
Built by: Benchmarks #4638
Commit: 530f887

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	12.03ms - 12.73ms	-	unsure 🔍 -7% - +1% -0.91ms - +0.08ms	unsure 🔍 -6% - +2% -0.73ms - +0.25ms
tip-of-tree tip-of-tree	12.44ms - 13.15ms	unsure 🔍 -1% - +7% -0.08ms - +0.91ms	-	unsure 🔍 -3% - +5% -0.31ms - +0.67ms
previous-release previous-release	12.27ms - 12.96ms	unsure 🔍 -2% - +6% -0.25ms - +0.73ms	unsure 🔍 -5% - +2% -0.67ms - +0.31ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	351.66ms - 364.87ms	-	unsure 🔍 -1% - +4% -4.15ms - +13.53ms	unsure 🔍 -1% - +4% -3.92ms - +12.82ms
tip-of-tree tip-of-tree	347.70ms - 359.45ms	unsure 🔍 -4% - +1% -13.53ms - +4.15ms	-	unsure 🔍 -2% - +2% -8.05ms - +7.56ms
previous-release previous-release	348.68ms - 358.95ms	unsure 🔍 -4% - +1% -12.82ms - +3.92ms	unsure 🔍 -2% - +2% -7.56ms - +8.05ms	-

lit-html-template-heavy

Browser: chrome-headless 111.0.5563.146
Sample size: 50
Built by: Benchmarks #4638
Commit: 530f887

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	66.11ms - 69.63ms	-	unsure 🔍 -4% - +2% -2.78ms - +1.42ms	unsure 🔍 -5% - +2% -3.38ms - +1.21ms
tip-of-tree tip-of-tree	67.40ms - 69.70ms	unsure 🔍 -2% - +4% -1.42ms - +2.78ms	-	unsure 🔍 -3% - +2% -2.28ms - +1.46ms
previous-release previous-release	67.48ms - 70.44ms	unsure 🔍 -2% - +5% -1.21ms - +3.38ms	unsure 🔍 -2% - +3% -1.46ms - +2.28ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	141.66ms - 144.48ms	-	unsure 🔍 -2% - +1% -2.71ms - +2.03ms	unsure 🔍 -2% - +2% -2.65ms - +2.21ms
tip-of-tree tip-of-tree	141.50ms - 145.32ms	unsure 🔍 -1% - +2% -2.03ms - +2.71ms	-	unsure 🔍 -2% - +2% -2.63ms - +2.87ms
previous-release previous-release	141.31ms - 145.27ms	unsure 🔍 -2% - +2% -2.21ms - +2.65ms	unsure 🔍 -2% - +2% -2.87ms - +2.63ms	-

reactive-element-list

Browser: chrome-headless 111.0.5563.146
Sample size: 50
Built by: Benchmarks #4638
Commit: 530f887

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	59.73ms - 63.09ms	-	unsure 🔍 -1% - +6% -0.80ms - +3.51ms	unsure 🔍 -2% - +6% -0.94ms - +3.63ms
tip-of-tree tip-of-tree	58.71ms - 61.40ms	unsure 🔍 -6% - +1% -3.51ms - +0.80ms	-	unsure 🔍 -3% - +3% -2.06ms - +2.04ms
previous-release previous-release	58.52ms - 61.61ms	unsure 🔍 -6% - +1% -3.63ms - +0.94ms	unsure 🔍 -3% - +3% -2.04ms - +2.06ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	946.14ms - 956.60ms	-	unsure 🔍 -1% - +1% -6.06ms - +8.08ms	unsure 🔍 -1% - +0% -10.77ms - +3.94ms
tip-of-tree tip-of-tree	945.61ms - 955.12ms	unsure 🔍 -1% - +1% -8.08ms - +6.06ms	-	unsure 🔍 -1% - +0% -11.45ms - +2.60ms
previous-release previous-release	949.62ms - 959.96ms	unsure 🔍 -0% - +1% -3.94ms - +10.77ms	unsure 🔍 -0% - +1% -2.60ms - +11.45ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	931.54ms - 941.22ms	-	unsure 🔍 -1% - +1% -6.37ms - +7.02ms	unsure 🔍 -1% - +0% -8.19ms - +4.39ms
tip-of-tree tip-of-tree	931.43ms - 940.68ms	unsure 🔍 -1% - +1% -7.02ms - +6.37ms	-	unsure 🔍 -1% - +0% -8.35ms - +3.90ms
previous-release previous-release	934.26ms - 942.30ms	unsure 🔍 -0% - +1% -4.39ms - +8.19ms	unsure 🔍 -0% - +1% -3.90ms - +8.35ms	-

_{tachometer-reporter-action v2 for Benchmarks}

MrHBS · 2023-04-03T13:25:35Z

Shouldn’t it be esnext in tsconfig.json? I believe you are not using typescript for downleveling.

augustjk · 2023-04-05T23:58:28Z

Maybe we should drop this line from CONTRIBUTING.md since we actually do downlevel

lit/CONTRIBUTING.md

Line 64 in 21e22cc

    
           1. We compile to the `esnext` target and don't use TypeScript for "downlevel" compilation. Do not change that.

…o 3.0-es-year

abdonrd · 2023-04-12T09:26:41Z

Looking at this... Wouldn't it help to have a shared tsconfig.json between most packages?

augustjk · 2023-04-13T01:30:03Z

Looking at this... Wouldn't it help to have a shared tsconfig.json between most packages?

We totally do this for the lit/lit.dev repo. Maybe we should consider that for here too.

justinfagnani · 2023-04-13T02:06:55Z

Maybe, but not in this PR. Let's keep this as simple as possible.

Upgrade build targets to ES2021

596a996

justinfagnani requested review from rictic and augustjk March 31, 2023 00:38

justinfagnani requested a review from benjamind as a code owner March 31, 2023 00:38

justinfagnani added the 3.0 label Mar 31, 2023

rictic approved these changes Mar 31, 2023

View reviewed changes

rictic mentioned this pull request Mar 31, 2023

[all] Size regression when emitting ES2021 #3777

Closed

augustjk added 3 commits April 5, 2023 16:25

Update gen wrapper tsconfig templates

a84072a

Update more spots to es2021

f53f939

Update virtualizer readme

e188171

augustjk mentioned this pull request Apr 10, 2023

[all] Lit 3.0 prereleases #3774

Closed

10 tasks

augustjk approved these changes Apr 10, 2023

View reviewed changes

justinfagnani and others added 10 commits April 10, 2023 14:29

Update Safari tests to Safari 15

7f3f827

Try macOS 12/Safari@latest

448a2bf

Try lower case safari

365db5d

Try acceptInsecureCerts: false

5287899

Merge branch '3.0-es-year' of https://github.com/Polymer/lit-html int…

15fa3de

…o 3.0-es-year

Increase testsStartTimeout

8f0bc12

Try macOS 13/safari@latest

ef4dccd

Revert the Safari changes

e0a5d67

Revert testsStartTimeout

1e2ee32

Merge branch '3.0' into 3.0-es-year

4ef10ca

justinfagnani merged commit 85ca81a into 3.0 Apr 14, 2023
7 checks passed

justinfagnani deleted the 3.0-es-year branch April 14, 2023 01:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade build targets to ES2021 #3775

Upgrade build targets to ES2021 #3775

justinfagnani commented Mar 31, 2023

changeset-bot bot commented Mar 31, 2023 •

edited

github-actions bot commented Mar 31, 2023 •

edited

📊 Tachometer Benchmark Results

Summary

nop-update

render

update

update-reflect

Results

render

update

update-reflect

render

update

nop-update

render

update

render

update

render

update

update-reflect

MrHBS commented Apr 3, 2023

augustjk commented Apr 5, 2023

abdonrd commented Apr 12, 2023

augustjk commented Apr 13, 2023

justinfagnani commented Apr 13, 2023

Upgrade build targets to ES2021 #3775

Upgrade build targets to ES2021 #3775

Conversation

justinfagnani commented Mar 31, 2023

changeset-bot bot commented Mar 31, 2023 • edited

⚠️ No Changeset found

github-actions bot commented Mar 31, 2023 • edited

📊 Tachometer Benchmark Results

Summary

nop-update

render

update

update-reflect

Results

render

update

update-reflect

render

update

nop-update

render

update

render

update

render

update

update-reflect

MrHBS commented Apr 3, 2023

augustjk commented Apr 5, 2023

abdonrd commented Apr 12, 2023

augustjk commented Apr 13, 2023

justinfagnani commented Apr 13, 2023

changeset-bot bot commented Mar 31, 2023 •

edited

github-actions bot commented Mar 31, 2023 •

edited