Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow to set props as attributes in react wrapper #4476

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jeripeierSBB
Copy link

@jeripeierSBB jeripeierSBB commented Jan 4, 2024

Fixes #4023
Fixes #4435
Closes #4436

It's an attempt to bring this topic further, no final solution.

Tests are missing, but I'd provide them if architecture of solution would be clear.

Copy link

changeset-bot bot commented Jan 4, 2024

🦋 Changeset detected

Latest commit: a412b1d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@lit/react Minor
@lit-internal/test-elements-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 4, 2024

📊 Tachometer Benchmark Results

Summary

A summary of the benchmark results will show here once they finish.

Results

The full results of your benchmarks will show here once they finish.

tachometer-reporter-action v2 for Benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant