[labs/ssr-dom-shim] Patch localName and tagName with customElements.define call #4553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4e21c3f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
📊 Tachometer Benchmark ResultsSummaryA summary of the benchmark results will show here once they finish. ResultsThe full results of your benchmarks will show here once they finish. |
kyubisation
changed the title
kyubisation
force-pushed
the
fix-ssr-local-name
branch
2 times, most recently
from
1896c91
to
4ed2986
Compare
|
Sorry, I missed the section in |
justinfagnani
requested changes
May 28, 2024
…lements.define call This change extends the CustomElementRegistryShim to patch localName and tagName into the web component, when calling define. This allows instances to call `this.localName` and `this.tagName` accordingly. Fixes lit#3375
…customElements.define call
Co-authored-by: Justin Fagnani <justin@fagnani.com>
kyubisation
force-pushed
the
fix-ssr-local-name
branch
from
d077c4b
to
4e21c3f
Compare
justinfagnani
approved these changes
Jun 9, 2024
|
@justinfagnani Thank you for the review, advice and merge! 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change extends the CustomElementRegistryShim to patch localName and tagName into the web component, when calling define.
This allows instances to call
this.localNameandthis.tagNameaccordingly.Fixes #3375