Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update MDN url for attributeChangedCallback() #4560

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

38elements
Copy link
Contributor

Copy link

changeset-bot bot commented Feb 24, 2024

⚠️ No Changeset found

Latest commit: 03375f1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Mar 22, 2024

📊 Tachometer Benchmark Results

Summary

nop-update

  • this-change, tip-of-tree, previous-release: unsure 🔍 -5% - +4% (-0.50ms - +0.48ms)
    this-change vs tip-of-tree

render

  • this-change: 45.70ms - 48.71ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -4% - +2% (-0.74ms - +0.44ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -3% - +1% (-0.97ms - +0.40ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -3% - +1% (-1.01ms - +0.30ms)
    this-change vs tip-of-tree

update

  • this-change: 478.97ms - 492.27ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -9% - +4% (-3.81ms - +1.49ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -4% - +1% (-2.55ms - +0.54ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -3% - +2% (-13.63ms - +11.48ms)
    this-change vs tip-of-tree

update-reflect

  • this-change: 487.31ms - 495.45ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +3% (-9.37ms - +13.55ms)
    this-change vs tip-of-tree

Results

this-change

render

VersionAvg timevs
45.70ms - 48.71ms-

update

VersionAvg timevs
478.97ms - 492.27ms-

update-reflect

VersionAvg timevs
487.31ms - 495.45ms-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
18.09ms - 18.91ms-unsure 🔍
-4% - +2%
-0.74ms - +0.44ms
unsure 🔍
-5% - +1%
-1.04ms - +0.21ms
tip-of-tree
tip-of-tree
18.23ms - 19.08msunsure 🔍
-2% - +4%
-0.44ms - +0.74ms
-unsure 🔍
-5% - +2%
-0.90ms - +0.37ms
previous-release
previous-release
18.44ms - 19.39msunsure 🔍
-1% - +6%
-0.21ms - +1.04ms
unsure 🔍
-2% - +5%
-0.37ms - +0.90ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
38.13ms - 41.26ms-unsure 🔍
-9% - +4%
-3.81ms - +1.49ms
unsure 🔍
-9% - +2%
-3.94ms - +0.98ms
tip-of-tree
tip-of-tree
38.71ms - 43.00msunsure 🔍
-4% - +10%
-1.49ms - +3.81ms
-unsure 🔍
-8% - +6%
-3.18ms - +2.54ms
previous-release
previous-release
39.28ms - 43.07msunsure 🔍
-3% - +10%
-0.98ms - +3.94ms
unsure 🔍
-6% - +8%
-2.54ms - +3.18ms
-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
10.80ms - 11.41ms-unsure 🔍
-5% - +4%
-0.50ms - +0.48ms
unsure 🔍
-4% - +5%
-0.45ms - +0.52ms
tip-of-tree
tip-of-tree
10.74ms - 11.50msunsure 🔍
-4% - +5%
-0.48ms - +0.50ms
-unsure 🔍
-4% - +5%
-0.49ms - +0.58ms
previous-release
previous-release
10.70ms - 11.45msunsure 🔍
-5% - +4%
-0.52ms - +0.45ms
unsure 🔍
-5% - +4%
-0.58ms - +0.49ms
-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
32.83ms - 33.73ms-unsure 🔍
-3% - +1%
-0.97ms - +0.40ms
unsure 🔍
-3% - +1%
-0.86ms - +0.46ms
tip-of-tree
tip-of-tree
33.05ms - 34.08msunsure 🔍
-1% - +3%
-0.40ms - +0.97ms
-unsure 🔍
-2% - +2%
-0.62ms - +0.79ms
previous-release
previous-release
32.99ms - 33.96msunsure 🔍
-1% - +3%
-0.46ms - +0.86ms
unsure 🔍
-2% - +2%
-0.79ms - +0.62ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
67.68ms - 69.18ms-unsure 🔍
-4% - +1%
-2.55ms - +0.54ms
unsure 🔍
-3% - +1%
-1.86ms - +0.44ms
tip-of-tree
tip-of-tree
68.09ms - 70.79msunsure 🔍
-1% - +4%
-0.54ms - +2.55ms
-unsure 🔍
-2% - +3%
-1.31ms - +1.90ms
previous-release
previous-release
68.27ms - 70.01msunsure 🔍
-1% - +3%
-0.44ms - +1.86ms
unsure 🔍
-3% - +2%
-1.90ms - +1.31ms
-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
30.89ms - 31.72ms-unsure 🔍
-3% - +1%
-1.01ms - +0.30ms
unsure 🔍
-4% - +0%
-1.34ms - +0.16ms
tip-of-tree
tip-of-tree
31.15ms - 32.16msunsure 🔍
-1% - +3%
-0.30ms - +1.01ms
-unsure 🔍
-3% - +2%
-1.04ms - +0.56ms
previous-release
previous-release
31.27ms - 32.52msunsure 🔍
-1% - +4%
-0.16ms - +1.34ms
unsure 🔍
-2% - +3%
-0.56ms - +1.04ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
501.29ms - 519.07ms-unsure 🔍
-3% - +2%
-13.63ms - +11.48ms
unsure 🔍
-3% - +3%
-12.99ms - +12.90ms
tip-of-tree
tip-of-tree
502.39ms - 520.13msunsure 🔍
-2% - +3%
-11.48ms - +13.63ms
-unsure 🔍
-2% - +3%
-11.90ms - +13.96ms
previous-release
previous-release
500.82ms - 519.64msunsure 🔍
-3% - +3%
-12.90ms - +12.99ms
unsure 🔍
-3% - +2%
-13.96ms - +11.90ms
-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
509.36ms - 526.20ms-unsure 🔍
-2% - +3%
-9.37ms - +13.55ms
unsure 🔍
-2% - +2%
-12.54ms - +11.28ms
tip-of-tree
tip-of-tree
507.92ms - 523.46msunsure 🔍
-3% - +2%
-13.55ms - +9.37ms
-unsure 🔍
-3% - +2%
-14.18ms - +8.74ms
previous-release
previous-release
509.99ms - 526.84msunsure 🔍
-2% - +2%
-11.28ms - +12.54ms
unsure 🔍
-2% - +3%
-8.74ms - +14.18ms
-

tachometer-reporter-action v2 for Benchmarks

Copy link
Contributor

The size of lit-html.js and lit-core.min.js are as expected.

@justinfagnani justinfagnani merged commit 23121c2 into lit:main Mar 26, 2024
6 of 7 checks passed
@38elements 38elements deleted the patch-1 branch March 29, 2024 12:58
@38elements 38elements restored the patch-1 branch March 29, 2024 12:58
@38elements 38elements deleted the patch-1 branch March 29, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants