Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link to constructible stylesheets explainer #4607

Merged
merged 3 commits into from Apr 23, 2024

Conversation

peschee
Copy link
Contributor

@peschee peschee commented Apr 1, 2024

The original link seems to point to a 404 page. I've changed the link to point to the explainer markdown in the orginal repo.

Copy link

changeset-bot bot commented Apr 1, 2024

🦋 Changeset detected

Latest commit: 1f1325d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Apr 1, 2024

📊 Tachometer Benchmark Results

Summary

nop-update

  • this-change, tip-of-tree, previous-release: unsure 🔍 -9% - +4% (-1.00ms - +0.50ms)
    this-change vs tip-of-tree

render

  • this-change: 44.50ms - 46.36ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -3% - +6% (-0.52ms - +1.02ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +3% (-0.77ms - +1.03ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -0% - +3% (-0.07ms - +0.85ms)
    this-change vs tip-of-tree

update

  • this-change: 473.45ms - 481.99ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -6% - +6% (-2.34ms - +2.36ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +3% (-0.98ms - +2.08ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +1% (-3.53ms - +5.04ms)
    this-change vs tip-of-tree

update-reflect

  • this-change: 482.56ms - 491.42ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +1% (-5.12ms - +5.66ms)
    this-change vs tip-of-tree

Results

this-change

render

VersionAvg timevs
44.50ms - 46.36ms-

update

VersionAvg timevs
473.45ms - 481.99ms-

update-reflect

VersionAvg timevs
482.56ms - 491.42ms-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
17.97ms - 19.13ms-unsure 🔍
-3% - +6%
-0.52ms - +1.02ms
unsure 🔍
-4% - +4%
-0.78ms - +0.80ms
tip-of-tree
tip-of-tree
17.80ms - 18.81msunsure 🔍
-5% - +3%
-1.02ms - +0.52ms
-unsure 🔍
-5% - +3%
-0.98ms - +0.50ms
previous-release
previous-release
18.01ms - 19.08msunsure 🔍
-4% - +4%
-0.80ms - +0.78ms
unsure 🔍
-3% - +5%
-0.50ms - +0.98ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
37.45ms - 40.86ms-unsure 🔍
-6% - +6%
-2.34ms - +2.36ms
unsure 🔍
-9% - +2%
-3.75ms - +0.93ms
tip-of-tree
tip-of-tree
37.52ms - 40.76msunsure 🔍
-6% - +6%
-2.36ms - +2.34ms
-unsure 🔍
-9% - +2%
-3.70ms - +0.86ms
previous-release
previous-release
38.96ms - 42.16msunsure 🔍
-2% - +10%
-0.93ms - +3.75ms
unsure 🔍
-2% - +10%
-0.86ms - +3.70ms
-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
10.83ms - 11.54ms-unsure 🔍
-9% - +4%
-1.00ms - +0.50ms
unsure 🔍
-7% - +1%
-0.84ms - +0.12ms
tip-of-tree
tip-of-tree
10.78ms - 12.09msunsure 🔍
-4% - +9%
-0.50ms - +1.00ms
-unsure 🔍
-7% - +5%
-0.83ms - +0.62ms
previous-release
previous-release
11.23ms - 11.86msunsure 🔍
-1% - +8%
-0.12ms - +0.84ms
unsure 🔍
-5% - +7%
-0.62ms - +0.83ms
-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
33.86ms - 34.98ms-unsure 🔍
-2% - +3%
-0.77ms - +1.03ms
unsure 🔍
-5% - +0%
-1.86ms - +0.18ms
tip-of-tree
tip-of-tree
33.58ms - 34.99msunsure 🔍
-3% - +2%
-1.03ms - +0.77ms
-unsure 🔍
-6% - +0%
-2.09ms - +0.13ms
previous-release
previous-release
34.41ms - 36.12msunsure 🔍
-1% - +5%
-0.18ms - +1.86ms
unsure 🔍
-0% - +6%
-0.13ms - +2.09ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
73.29ms - 75.84ms-unsure 🔍
-1% - +3%
-0.98ms - +2.08ms
unsure 🔍
-5% - +1%
-3.53ms - +1.12ms
tip-of-tree
tip-of-tree
73.18ms - 74.86msunsure 🔍
-3% - +1%
-2.08ms - +0.98ms
-unsure 🔍
-5% - +0%
-3.86ms - +0.36ms
previous-release
previous-release
73.83ms - 77.71msunsure 🔍
-2% - +5%
-1.12ms - +3.53ms
unsure 🔍
-1% - +5%
-0.36ms - +3.86ms
-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
30.57ms - 31.34ms-unsure 🔍
-0% - +3%
-0.07ms - +0.85ms
unsure 🔍
-1% - +3%
-0.16ms - +0.82ms
tip-of-tree
tip-of-tree
30.31ms - 30.82msunsure 🔍
-3% - +0%
-0.85ms - +0.07ms
-unsure 🔍
-2% - +1%
-0.46ms - +0.34ms
previous-release
previous-release
30.32ms - 30.94msunsure 🔍
-3% - +1%
-0.82ms - +0.16ms
unsure 🔍
-1% - +2%
-0.34ms - +0.46ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
472.67ms - 478.70ms-unsure 🔍
-1% - +1%
-3.53ms - +5.04ms
unsure 🔍
-1% - +1%
-5.49ms - +3.50ms
tip-of-tree
tip-of-tree
471.89ms - 477.97msunsure 🔍
-1% - +1%
-5.04ms - +3.53ms
-unsure 🔍
-1% - +1%
-6.27ms - +2.76ms
previous-release
previous-release
473.35ms - 480.02msunsure 🔍
-1% - +1%
-3.50ms - +5.49ms
unsure 🔍
-1% - +1%
-2.76ms - +6.27ms
-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
515.39ms - 523.51ms-unsure 🔍
-1% - +1%
-5.12ms - +5.66ms
unsure 🔍
-1% - +1%
-5.60ms - +5.90ms
tip-of-tree
tip-of-tree
515.64ms - 522.73msunsure 🔍
-1% - +1%
-5.66ms - +5.12ms
-unsure 🔍
-1% - +1%
-5.52ms - +5.28ms
previous-release
previous-release
515.23ms - 523.38msunsure 🔍
-1% - +1%
-5.90ms - +5.60ms
unsure 🔍
-1% - +1%
-5.28ms - +5.52ms
-

tachometer-reporter-action v2 for Benchmarks

@justinfagnani justinfagnani changed the title Fix 404 link Fix link to constructible stylesheets explainer Apr 1, 2024
Copy link
Collaborator

@justinfagnani justinfagnani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

This just needs an empty changeset file. See https://github.com/lit/lit/blob/main/CONTRIBUTING.md#pull-requests

packages/reactive-element/src/css-tag.ts Outdated Show resolved Hide resolved
@peschee
Copy link
Contributor Author

peschee commented Apr 23, 2024

Thanks!

This just needs an empty changeset file. See https://github.com/lit/lit/blob/main/CONTRIBUTING.md#pull-requests

Done

peschee and others added 3 commits April 23, 2024 09:21
The original link seems to point to a 404 page. I've changed the link to point to the explainer markdown in the orginal repo.
Co-authored-by: Justin Fagnani <justin@fagnani.com>
Copy link
Collaborator

@justinfagnani justinfagnani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@justinfagnani justinfagnani merged commit 83d0482 into lit:main Apr 23, 2024
7 checks passed
@peschee peschee deleted the docs/fix-link branch April 23, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants