Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version Packages #4632

Merged
merged 1 commit into from Apr 25, 2024
Merged

Version Packages #4632

merged 1 commit into from Apr 25, 2024

Conversation

lit-robot
Copy link
Member

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

@lit-labs/nextjs@0.2.0

Minor Changes

  • #4575 aa4fc3ef - Add support for Next.js 14 and App Router. No longer support Next.js 12.

    Note: By default, components in the App Router are React Server Components (RSCs). Deep SSR of Lit components does not work within server components as they result in React hydration mismatch due to the presence of the <template> element in the RSC payload containing the serialized server component tree, and the custom element definitions will not be included with the client bundle either when imported in server component files.

    Make sure any Lit components you wish to use are beyond the 'use client'; boundary. These will still be server rendered for the initial page load just like they did for the Pages Router.

Patch Changes

@lit-labs/ssr-react@0.3.0

Minor Changes

  • #4575 aa4fc3ef - The Node build of @lit-labs/ssr-react/enable-lit-ssr.js now also monkey-patches react/jsx-runtime to include logic for deeply server-rendering Lit components without modifying jsxImportSource in tsconfig.

    The monkey-patching logic also adds a workaround for inconsistent es module interop behavior in tools like webpack which could lead to errors like TypeError: Cannot set property createElement of [object Module] which has only a getter.

Patch Changes

  • #4575 aa4fc3ef - Use a global flag to detect whether @lit-labs/ssr-react/enable-lit-ssr.js was used for coordinating props when server rendering components made with @lit/react.

@lit/react@1.0.5

Patch Changes

  • #4575 aa4fc3ef - Use a global flag to detect whether @lit-labs/ssr-react/enable-lit-ssr.js was used for coordinating props when server rendering components made with @lit/react.

@lit-examples/nextjs-v13@0.1.2

Patch Changes

  • Updated dependencies [aa4fc3ef]:
    • @lit-labs/nextjs@0.2.0

@lit-examples/nextjs-v14@0.0.1

Patch Changes

  • Updated dependencies [aa4fc3ef]:
    • @lit-labs/nextjs@0.2.0

@lit-examples/nextjs-v14-app@0.0.1

Patch Changes

  • Updated dependencies [aa4fc3ef]:
    • @lit-labs/nextjs@0.2.0

@lit-internal/test-elements-react@1.0.6

Patch Changes

  • Updated dependencies [aa4fc3ef]:
    • @lit/react@1.0.5

Copy link
Contributor

github-actions bot commented Apr 25, 2024

📊 Tachometer Benchmark Results

Summary

nop-update

  • this-change, tip-of-tree, previous-release: unsure 🔍 -3% - +5% (-0.28ms - +0.56ms)
    this-change vs tip-of-tree

render

  • this-change: 44.98ms - 46.99ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -5% - +2% (-0.95ms - +0.38ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +2% (-0.42ms - +0.62ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: slower ❌ 0% - 5% (0.03ms - 1.48ms)
    this-change vs tip-of-tree

update

  • this-change: 469.86ms - 477.34ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -8% - +8% (-3.06ms - +3.28ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -3% - +2% (-2.25ms - +1.27ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +2% (-9.75ms - +10.42ms)
    this-change vs tip-of-tree

update-reflect

  • this-change: 476.53ms - 483.53ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -0% - +2% (-1.87ms - +10.52ms)
    this-change vs tip-of-tree

Results

this-change

render

VersionAvg timevs
44.98ms - 46.99ms-

update

VersionAvg timevs
469.86ms - 477.34ms-

update-reflect

VersionAvg timevs
476.53ms - 483.53ms-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
18.00ms - 18.89ms-unsure 🔍
-5% - +2%
-0.95ms - +0.38ms
unsure 🔍
-3% - +3%
-0.64ms - +0.64ms
tip-of-tree
tip-of-tree
18.24ms - 19.23msunsure 🔍
-2% - +5%
-0.38ms - +0.95ms
-unsure 🔍
-2% - +5%
-0.39ms - +0.96ms
previous-release
previous-release
17.98ms - 18.91msunsure 🔍
-3% - +3%
-0.64ms - +0.64ms
unsure 🔍
-5% - +2%
-0.96ms - +0.39ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
36.14ms - 41.31ms-unsure 🔍
-8% - +8%
-3.06ms - +3.28ms
unsure 🔍
-3% - +13%
-1.18ms - +4.72ms
tip-of-tree
tip-of-tree
36.78ms - 40.45msunsure 🔍
-8% - +8%
-3.28ms - +3.06ms
-unsure 🔍
-2% - +11%
-0.66ms - +3.98ms
previous-release
previous-release
35.54ms - 38.37msunsure 🔍
-12% - +3%
-4.72ms - +1.18ms
unsure 🔍
-10% - +2%
-3.98ms - +0.66ms
-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
10.71ms - 11.27ms-unsure 🔍
-3% - +5%
-0.28ms - +0.56ms
unsure 🔍
-1% - +7%
-0.08ms - +0.79ms
tip-of-tree
tip-of-tree
10.54ms - 11.16msunsure 🔍
-5% - +3%
-0.56ms - +0.28ms
-unsure 🔍
-2% - +6%
-0.24ms - +0.67ms
previous-release
previous-release
10.31ms - 10.97msunsure 🔍
-7% - +1%
-0.79ms - +0.08ms
unsure 🔍
-6% - +2%
-0.67ms - +0.24ms
-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
33.50ms - 34.34ms-unsure 🔍
-1% - +2%
-0.42ms - +0.62ms
unsure 🔍
-2% - +1%
-0.55ms - +0.50ms
tip-of-tree
tip-of-tree
33.51ms - 34.13msunsure 🔍
-2% - +1%
-0.62ms - +0.42ms
-unsure 🔍
-2% - +1%
-0.56ms - +0.32ms
previous-release
previous-release
33.63ms - 34.25msunsure 🔍
-1% - +2%
-0.50ms - +0.55ms
unsure 🔍
-1% - +2%
-0.32ms - +0.56ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
70.09ms - 72.51ms-unsure 🔍
-3% - +2%
-2.25ms - +1.27ms
unsure 🔍
-3% - +2%
-2.24ms - +1.18ms
tip-of-tree
tip-of-tree
70.51ms - 73.07msunsure 🔍
-2% - +3%
-1.27ms - +2.25ms
-unsure 🔍
-3% - +2%
-1.81ms - +1.72ms
previous-release
previous-release
70.62ms - 73.04msunsure 🔍
-2% - +3%
-1.18ms - +2.24ms
unsure 🔍
-2% - +3%
-1.72ms - +1.81ms
-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
31.50ms - 32.73ms-slower ❌
0% - 5%
0.03ms - 1.48ms
unsure 🔍
-1% - +4%
-0.16ms - +1.40ms
tip-of-tree
tip-of-tree
30.98ms - 31.74msfaster ✔
0% - 5%
0.03ms - 1.48ms
-unsure 🔍
-2% - +2%
-0.75ms - +0.48ms
previous-release
previous-release
31.02ms - 31.98msunsure 🔍
-4% - +0%
-1.40ms - +0.16ms
unsure 🔍
-2% - +2%
-0.48ms - +0.75ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
483.85ms - 498.01ms-unsure 🔍
-2% - +2%
-9.75ms - +10.42ms
unsure 🔍
-1% - +2%
-5.48ms - +11.79ms
tip-of-tree
tip-of-tree
483.41ms - 497.79msunsure 🔍
-2% - +2%
-10.42ms - +9.75ms
-unsure 🔍
-1% - +2%
-5.91ms - +11.55ms
previous-release
previous-release
482.83ms - 492.73msunsure 🔍
-2% - +1%
-11.79ms - +5.48ms
unsure 🔍
-2% - +1%
-11.55ms - +5.91ms
-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
524.89ms - 534.38ms-unsure 🔍
-0% - +2%
-1.87ms - +10.52ms
unsure 🔍
-1% - +1%
-7.16ms - +5.65ms
tip-of-tree
tip-of-tree
521.33ms - 529.29msunsure 🔍
-2% - +0%
-10.52ms - +1.87ms
-unsure 🔍
-2% - +0%
-10.94ms - +0.79ms
previous-release
previous-release
526.08ms - 534.70msunsure 🔍
-1% - +1%
-5.65ms - +7.16ms
unsure 🔍
-0% - +2%
-0.79ms - +10.94ms
-

tachometer-reporter-action v2 for Benchmarks

Copy link
Contributor

The size of lit-html.js and lit-core.min.js are as expected.

Copy link
Member

@augustjk augustjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noting that the release consideration for #4575 was verified.
@lit-labs/nextjs's dependency on @lit-labs/ssr-react is getting bumped lock-step.

@augustjk augustjk merged commit 56cb2ca into main Apr 25, 2024
10 checks passed
@augustjk augustjk deleted the changeset-release/main branch April 25, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants