Analyst Ratings #106
Open
Analyst Ratings #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed names of some functions and variables to align with the wording used on the Finviz website:
outer ratings to analyst ratings
inside trader to insider trading
fundament to fundamentals
Type of change
What you did
In quote.py renamed some methods:
renamed ticker_fundament to ticker_fundamentals
renamed ticker_outer_ratings to ticker_analyst_ratings
renamed ticker_inside_trader to ticker_insider_trading
In quote.py renamed some variables:
renamed fundament to fundamentals
renamed fundament_info to fundamentals_info
renamed fundament_table to fundamentals_table
renamed fullview_ratings_outer to fullview_ratings_analyst
renamed outer to analyst
renamed inside_trader to insider_trading
In quote.py renamed some dictionary keys:
in info renamed fundament to fundamentals
in info renamed ratings_outer to ratings_analyst
in info renamed inside_trader to insider_trading
in info_dict renamed Outer to Analyst
Tried to find all occurrences of these changes in other files and updated.