Sourcery refactored code #69
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sourcery refactored master branch
|
I think f-strings only support in Python 3.6 or later |
|
That is correct. Should I then remove that part of the refactoring? |
I think so. |
lit26
reviewed
Jul 29, 2023
| @@ -158,33 +154,32 @@ def _parse_column(self, cols, raw, fundament_info): | |||
| for i, value in enumerate(cols): | |||
| if i % 2 == 0: | |||
| header = value | |||
| elif header == "Volatility": | |||
There was a problem hiding this comment.
I don't think this change is necessary. The first if else is just checking whether it is header or value
|
Resolve conflict also |
Done. Please merge. |
|
There is another issue. Please check. |
|
@lit26 Can you merge this and close the PR? |
|
https://github.com/lit26/finvizfinance/pull/69/files#r1189156258. You still need to solve this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sourcery refactored code to reflect modern coding practices.
Type of change
What you did