Add #all method to Lita::User, matching specs #103
Conversation
chriswoodrich
force-pushed
the
all-users
branch
2 times, most recently
from
8df4b40
to
f369594
Compare
|
What's the use case for this? |
|
Convenience for when a handler needs access to all the users for messaging On Sat, May 2, 2015 at 5:06 PM, Jimmy Cuadra notifications@github.com
|
| # Since 4.2.3 | ||
| def all | ||
| ids = redis.keys.select { |key| key.include? "id" }.map { |id| id.split(":").last }.sort | ||
| ids.each.map { |id| find_by_id(id) } |
There was a problem hiding this comment.
Should be ids.map { |id| find_by_id(id) }
.each.map is incorrect
|
I think we discussed this before, but unless there's something I'm not understanding about the use case, authorization groups are probably a better fit sending out mass messages. That way you can scope it to the purpose of the specific message and people it's relevant for. It's also worth noting that there will eventually be support for a "roster" feature that will tell you who is currently online, filterable by room. |
|
Thanks for this, but I think I'm going to close it in favor of a proper roster feature, which should be coming relatively soon. |
No description provided.