Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add syntax highlighting for Java constants and class names when creating objects. #385

Merged
merged 13 commits into from
Jul 19, 2024
Merged

Add syntax highlighting for Java constants and class names when creating objects. #385

merged 13 commits into from
Jul 19, 2024

Conversation

PerilousBooklet
Copy link
Contributor

No description provided.

@PerilousBooklet PerilousBooklet changed the title Add syntax highlighting for Java constants. Add syntax highlighting for Java constants and first-word-in-line class names. Mar 14, 2024
@PerilousBooklet PerilousBooklet marked this pull request as draft March 14, 2024 20:45
@PerilousBooklet
Copy link
Contributor Author

PerilousBooklet commented Apr 3, 2024 •
edited
Loading

I'm waiting for this to be solved to request a review.

@PerilousBooklet PerilousBooklet marked this pull request as ready for review April 21, 2024 18:23
@PerilousBooklet PerilousBooklet changed the title Add syntax highlighting for Java constants and first-word-in-line class names. Add syntax highlighting for Java constants and class names when creating objects. Apr 21, 2024
Guldoman
Guldoman reviewed Apr 22, 2024
View reviewed changes
Copy link
Member

@Guldoman Guldoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a version bump.

plugins/language_java.lua Outdated Show resolved Hide resolved
plugins/language_java.lua Outdated Show resolved Hide resolved
Guldoman
Guldoman reviewed Apr 22, 2024
View reviewed changes
plugins/language_java.lua Outdated Show resolved Hide resolved
@PerilousBooklet
Copy link
Contributor Author

I was a bit rough with the commits.
I forgot to git pull the previous conflict-solve.

@PerilousBooklet
Copy link
Contributor Author

OK, so this PR should be ready. The regex not-yet-implemented look-behind functionality is no longer necessary.

Guldoman
Guldoman reviewed Jul 15, 2024
View reviewed changes
plugins/language_java.lua Outdated Show resolved Hide resolved
@Guldoman Guldoman merged commit b4a9d65 into lite-xl:master Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Guldoman Guldoman Guldoman left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@PerilousBooklet @Guldoman