Skip to content

Commit

Permalink
Keyboard layout independent shortcuts
Browse files Browse the repository at this point in the history
  • Loading branch information
Jipok committed Dec 11, 2021
1 parent 994c62b commit c3b7234
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/api/system.c
View file
Expand Up @@ -106,7 +106,7 @@ static const char *get_key_name(const SDL_Event *e, char *buf) {
!(e->key.keysym.mod & KMOD_NUM)) {
return numpad[scancode - SDL_SCANCODE_KP_1];
} else {
strcpy(buf, SDL_GetKeyName(e->key.keysym.sym));
strcpy(buf, SDL_GetScancodeName(e->key.keysym.scancode));
str_tolower(buf);
return buf;
}
Expand Down

2 comments on commit c3b7234

@rgrams
Copy link

@rgrams rgrams commented on c3b7234 Dec 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not saying this is a bad thing, but there should probably be an obvious warning about it, or a toggle on the lua side. If this works the way I expect, then it will break all of my own shortcuts and all of the built-in ones that I'm used to, except those bound to A and M.

@Guldoman
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this works the way I expect, then it will break all of my own shortcuts and all of the built-in ones that I'm used to, except those bound to A and M.

What layout are you using? What is your use case?
Could you open an issue to better discuss this?

Please sign in to comment.