Added a smoothing and strikethrough option to font loading. #1087
Conversation
src/renderer.c
Outdated
| FT_Outline_Translate(outline, x_translation, 0 ); | ||
| if(smoothing) FT_Outline_Embolden(outline, 1 << 5); |
There was a problem hiding this comment.
5 might be too much, maybe 3 is a better value?
There was a problem hiding this comment.
I sort of just copied the thing they did in the original discussion, as that seemed to produce nice results. I don't know exactly what settings to do, so honestly I'll have to do a comparison somehow. We could also make the option a number if that's what's needed.
|
Can this be merged now? I want to use this option for myself. |
github-actions
bot
added
Category: Documentation
Category: Lua Core
Category: Meta
labels
|
OK this pr finally isn't like 3 lines |
aqilc
changed the title
| @@ -4,6 +4,7 @@ lhelper/ | |||
| submodules/ | |||
| subprojects/*/ | |||
| /appimage* | |||
| .vscode | |||
There was a problem hiding this comment.
Not really but it could be useful to others ;w;
src/renderer.c
Outdated
| float adv = metric->xadvance ? metric->xadvance : font->space_advance; | ||
|
|
||
| if (fonts[0]->style & FONT_STYLE_UNDERLINE) | ||
| ren_draw_rect((RenRect){x, y / surface_scale + font->height - 1, adv / surface_scale, font->underline_thickness * surface_scale}, color); |
There was a problem hiding this comment.
| ren_draw_rect((RenRect){x, y / surface_scale + font->height - 1, adv / surface_scale, font->underline_thickness * surface_scale}, color); | |
| ren_draw_rect((RenRect){pen_x, y / surface_scale + font->height - 1, adv / surface_scale, font->underline_thickness * surface_scale}, color); |
Also maybe instead of y / surface_scale + font->height - 1 it should be y / surface_scale + font->height - font->underline_thickness * surface_scale.
| @@ -15,7 +15,7 @@ | |||
| typedef struct RenFont RenFont; | |||
| typedef enum { FONT_HINTING_NONE, FONT_HINTING_SLIGHT, FONT_HINTING_FULL } ERenFontHinting; | |||
| typedef enum { FONT_ANTIALIASING_NONE, FONT_ANTIALIASING_GRAYSCALE, FONT_ANTIALIASING_SUBPIXEL } ERenFontAntialiasing; | |||
| typedef enum { FONT_STYLE_BOLD = 1, FONT_STYLE_ITALIC = 2, FONT_STYLE_UNDERLINE = 4 } ERenFontStyle; | |||
| typedef enum { FONT_STYLE_BOLD = 1, FONT_STYLE_ITALIC = 2, FONT_STYLE_UNDERLINE = 4, FONT_STYLE_SMOOTH = 8, FONT_STYLE_STRIKETHROUGH = 16 } ERenFontStyle; | |||
There was a problem hiding this comment.
I'd invert their position, but that's just me.
There was a problem hiding this comment.
I feel like smoothing is going to be used a lot more, and for every font the user would use anyways. Especially on macs and when trying to make fonts look similar to os renders.
There was a problem hiding this comment.
The logic is that strikethrough should be near underline, but it's not a big problem.
Co-authored-by: Guldoman <giulio.lettieri@gmail.com>
|
As per discussion on discord, this is good enough for now. Merging. |
…1087) * Added a smoothing option to font loading. * Added a font strikethrough option to font loading. * Fixed underline applying incorrectly in cases of non-underlined fallback fonts being used. Co-authored-by: Guldoman <giulio.lettieri@gmail.com>
Related to the discussion in #1079.