set arch tuple in meson #1254
Merged
set arch tuple in meson #1254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the existing preprocessor logic in C is kept for alternative compilation methods
|
This is actually a great solution and nobody else thought about looking if the build system already provided such facilities 😄, nice job! Also the meson tables in cpu-families and operating-systems just show us they use standard identifiers so we should be good to go. |
jgmdev
approved these changes
Dec 21, 2022
Closed
takase1121
pushed a commit
to takase1121/lite-xl
that referenced
this pull request
Jan 16, 2023
the existing preprocessor logic in C is kept for alternative compilation methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the existing preprocessor logic in C is kept for alternative compilation methods
supersedes #1213