fix: deadlock if error handler jumps somewhere else #1647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Category: C Core
Category: Documentation
Category: Lua Core
labels
Guldoman
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
Looks good, but I guess a review from @adamharrison is needed, as it's his territory.
Guldoman
approved these changes
Oct 21, 2023
Co-authored-by: Guldoman <giulio.lettieri@gmail.com>
takase1121
added a commit
to takase1121/lite-xl
that referenced
this pull request
Oct 24, 2023
…-xl#1647) * fix: deadlock if error handler jumps somewhere else * docs(dirmonitor): fix wrong data type in error callback * docs(dirmonitor): clarify coroutines and deadlocks * docs(dirmonitor): wording Co-authored-by: Guldoman <giulio.lettieri@gmail.com> --------- Co-authored-by: Guldoman <giulio.lettieri@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR complements #1599.
The root issue is that the check callback runs within a critical section. It is very possible to longjmp out of it via errors. This PR allows errors to be caught by an error handler. This prevents an error from escaping the critical section and cause a deadlock.
Likely fixes #1531, #1532 (maybe #1556 too?).