Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the autoreload plugin may cause errors or crashes when a doc with a (absolute) filename is no longer backed by an actual on disk file.
steps to reproduce:
causes an error if done from within lite-xl (e.g the treeview), a crash if done externally
The deeper issue is that docs keep their filename even when their backing files are deleted, however as far as i can make sense of the dirwatch, there doesn't seem to be a way to tell apart a rename from a deletion + creation. So clearing filenames would also make externally renamed docs dangling (which may be desired behavior?)
See:
https://github.com/lite-xl/lite-xl/blob/master/data/core/init.lua#L199