Virtual Lines #1713
Draft
Virtual Lines #1713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, finally I've decided to take a crack at virtual lines. This'll make things like word wrapping, code folding, highlighting, and other things like that significantly easier to implement.
I've also moved most things like selections from
doctodocviewso we don't have the weird issue of spilt views sharing selections and other things like that.Overall it should be a wash in terms of the amount of code; it's basically just unifying the disparate ways of modifying tokens to be drawn into a single system that hopefully won't overly affect performance.
I've also bumped the modversion as this is going to break a lot of stuff; I've tried to keep the interfaces roughly the same, but it's just too big a refactor to not bump modversion.
Also includes a codefolding plugin to take advantage of the new system.