Improve CommandView and autocomplete scroll behavior
#1732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add a config option for the maximum number of visible entries in the command palette.
Guldoman
force-pushed
the
PR_improve_lists_scroll_behavior
branch
from
e9d599e
to
309ee0d
Compare
|
LGTM. Didn't even notice the bug before, but yeah this fixes. |
takase1121
added a commit
that referenced
this pull request
Mar 23, 2024
* Make command palette item scrolling more natural Also add a config option for the maximum number of visible entries in the command palette. * Make `autocomplete` item scrolling more natural Co-authored-by: Guldoman <giulio.lettieri@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
Video.del.2024-02-29.05-42-43.webm
After:
Video.del.2024-02-29.05-39-18.webm
This also adds the config variable
config.max_visible_commandsto allow customizing the maximum number of visible command palette entries.