Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added in support for fallback font groupings. #616

Merged
merged 7 commits into from Oct 20, 2021

Conversation

adamharrison
Copy link
Member

Added in support for font groupings. Basically just reused the font metatable, but if on a table, will use those fonts as fallbacks if a glyph can't be found in the primary font. If a glyph still can't be found, will draw U+25A1; the white square.

Should close #591 .
Should close #611 .

Thoughts? I will likely be slimming this down if I can further.

@adamharrison
Copy link
Member Author

For reference, sample usage is like so:

syntax.code_font = renderer.font.group { font1, font2, ... } 

@adamharrison
Copy link
Member Author

Should close #518 .

@adamharrison
Copy link
Member Author

Hey; I'm going to target this for a merge on the 20th, if no one has any objections. It's a fairly self-contained change, that shouldn't affect any existing code, so hopefully it's non-controversial enough to just merge in.

@adamharrison adamharrison merged commit 3f1378a into lite-xl:master Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New font renderer doesn't display missing glyphs icon
1 participant