Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented system.get_process_id() #833

Merged
merged 1 commit into from Feb 4, 2022

Conversation

jgmdev
Copy link
Member

@jgmdev jgmdev commented Feb 4, 2022

This function exposes current lite-xl process id which is needed for LSP servers to properly shutdown in case lite-xl crashes as reported here: lite-xl/lite-xl-lsp#20

Copy link
Member

@Guldoman Guldoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is useful to have.

Also this made me notice that we're mixing #ifs and #ifdefs. Shouldn't we just use #if everywhere? Or is there any reason for the #ifdefs?

@jgmdev
Copy link
Member Author

jgmdev commented Feb 4, 2022

Yeah, this is useful to have.

Also this made me notice that we're mixing #ifs and #ifdefs. Shouldn't we just use #if everywhere? Or is there any reason for the #ifdefs?

I just followed the same convention used at the top of system.c

@adamharrison adamharrison merged commit 212d4e2 into lite-xl:master Feb 4, 2022
@adamharrison
Copy link
Member

Looks good; we can always clean the whole #if vs #ifdef stuff later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants