Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🦺[Tech Debt] Remove unnecessary var appInstallDate - Targets v3.12.0 #189

Closed
3 tasks
kcw-grunt opened this issue Jan 19, 2023 · 1 comment · Fixed by #200
Closed
3 tasks

🦺[Tech Debt] Remove unnecessary var appInstallDate - Targets v3.12.0 #189

kcw-grunt opened this issue Jan 19, 2023 · 1 comment · Fixed by #200
Assignees
@Iferencak
Labels
🏰 high-priority Of all issues, these are the most urgent 🦺 tech debt Actions that help maintain the repo and application
Milestone
Release v3.12.0

Comments

@kcw-grunt
Copy link
Member

kcw-grunt commented Jan 19, 2023 •
edited

Goal

Describe the work to be done

There is a variable that is not serving any real purpose and in fact caused instability for years. This code should be refactored.

Definition of Done

  • Targets v3.12.0
  • replace var appInstallDate with Date()
  • Monitor usage in Moonpay
@kcw-grunt kcw-grunt added the 🦺 tech debt Actions that help maintain the repo and application label Jan 19, 2023
@kcw-grunt kcw-grunt self-assigned this Jan 19, 2023
@kcw-grunt kcw-grunt added this to the v3.12.0 milestone Jan 19, 2023
@kcw-grunt kcw-grunt added the 🏰 high-priority Of all issues, these are the most urgent label Jan 19, 2023
@kcw-grunt
Copy link
Member Author

cc: @Iferencak

@kcw-grunt kcw-grunt assigned Iferencak and unassigned kcw-grunt Jan 19, 2023
@kcw-grunt kcw-grunt changed the title 🦺[Tech Debt] Remove unnecessary var appInstallDate 🦺[Tech Debt] Remove unnecessary var appInstallDate **Targets v3.12.0** Jan 19, 2023
@kcw-grunt kcw-grunt changed the title 🦺[Tech Debt] Remove unnecessary var appInstallDate **Targets v3.12.0** 🦺[Tech Debt] Remove unnecessary var appInstallDate *Targets v3.12.0* Jan 19, 2023
@kcw-grunt kcw-grunt changed the title 🦺[Tech Debt] Remove unnecessary var appInstallDate *Targets v3.12.0* 🦺[Tech Debt] Remove unnecessary var appInstallDate - Targets v3.12.0 Jan 19, 2023
@Iferencak Iferencak linked a pull request Feb 19, 2023 that will close this issue
Removed appInstallDate and replaced it with Date() #200
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Iferencak Iferencak

Labels
🏰 high-priority Of all issues, these are the most urgent 🦺 tech debt Actions that help maintain the repo and application
Projects
None yet
Milestone
Release v3.12.0
Development

Successfully merging a pull request may close this issue.

Removed appInstallDate and replaced it with Date() litecoin-foundation/litewallet-ios
2 participants
@kcw-grunt @Iferencak