Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🦺[Tech Debt] Remove cruft: BitID #57

Closed
3 of 4 tasks
kcw-grunt opened this issue Jun 7, 2021 · 4 comments · Fixed by #79
Closed
3 of 4 tasks

🦺[Tech Debt] Remove cruft: BitID #57

kcw-grunt opened this issue Jun 7, 2021 · 4 comments · Fixed by #79
Assignees
Labels
🦺 tech debt Actions that help maintain the repo and application

Comments

@kcw-grunt
Copy link
Member

kcw-grunt commented Jun 7, 2021

Goal

Describe the work to be done
Remove any references to the original fork (Breadwallet) where BitID was used. This was a service to be used by the BRD team and was never implemented in Litewallet (or Loafwallet).

It causes confusion and problems maintaining the codebase. It must be removed safely

Definition of Done

  • Open a working branch and let @kcw-grunt know
  • Identify S,M,L refactors
  • Branch off the working branch and write issues for the refactors.
  • Test with older and newer iOS devices and simulators
@kcw-grunt kcw-grunt added the 🦺 tech debt Actions that help maintain the repo and application label Jun 7, 2021
@kcw-grunt kcw-grunt assigned kcw-grunt and JCHeist and unassigned kcw-grunt Jun 7, 2021
@kcw-grunt
Copy link
Member Author

@JasperHeist I added #58 as a dependency to make sure it was done first.

@JCHeist
Copy link
Contributor

JCHeist commented Jun 13, 2021

@JasperHeist I added #58 as a dependency to make sure it was done first.

Do you want this or #58 done first? Right now it's showing this one has to be done first, is that what you wanted? @kcw-grunt

@JCHeist
Copy link
Contributor

JCHeist commented Jun 15, 2021

opened branch techdebt/Remove-cruft-BitID-57. Can you confirm I interpreted the "blocking" thing right? or do you want the BCash stuff done first?

@kcw-grunt
Copy link
Member Author

@JasperHeist I added #58 as a dependency to make sure it was done first.

Do you want this or #58 done first? Right now it's showing this one has to be done first, is that what you wanted? @kcw-grunt

Yes @JasperHeist you have interpreted this correctly The reason is BitID has less code and was never implemented by BRD/Breadwallet (from my quick assessment)

@JCHeist JCHeist linked a pull request Jul 14, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🦺 tech debt Actions that help maintain the repo and application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants