Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃[Tech Debt] Remove Cruft: Bcash #58

Closed
3 of 4 tasks
kcw-grunt opened this issue Jun 7, 2021 · 2 comments 路 Fixed by #79
Closed
3 of 4 tasks

馃[Tech Debt] Remove Cruft: Bcash #58

kcw-grunt opened this issue Jun 7, 2021 · 2 comments 路 Fixed by #79
Assignees
@JCHeist
Labels
馃 tech debt Actions that help maintain the repo and application

Comments

@kcw-grunt
Copy link
Member

kcw-grunt commented Jun 7, 2021 •
edited by JCHeist
Loading

Describe the work to be done
Remove any references to the original fork (Breadwallet) where Bcash was used. This was because Breadwallet was a BTC wallet and the BRD team were going to allow use of Bcash.

For us it causes confusion and problems maintaining the codebase. It must be removed safely

Definition of Done

  • Open a working branch and let @kcw-grunt know
  • Identify S,M,L refactors
  • Branch off the working branch and write issues for the refactors.
  • Test with older and newer iOS devices and simulators
@kcw-grunt kcw-grunt added the 馃 tech debt Actions that help maintain the repo and application label Jun 7, 2021
@kcw-grunt kcw-grunt mentioned this issue Jun 7, 2021
Closed
4 tasks
@kcw-grunt
Copy link
Member Author

kcw-grunt commented Jul 12, 2021 •
edited
Loading

Think you are ready to submit? It can be in stages @JasperHeist

@JCHeist
Copy link
Contributor

JCHeist commented Jul 12, 2021

Please see my question in #57

@JCHeist JCHeist linked a pull request Jul 14, 2021 that will close this issue
馃[Tech Debt]- Remove Cruft - BitID & Bcash References #79
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JCHeist JCHeist

Labels
馃 tech debt Actions that help maintain the repo and application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

馃[Tech Debt]- Remove Cruft - BitID & Bcash References litecoin-foundation/litewallet-ios
2 participants
@kcw-grunt @JCHeist