added jumphost as a runner for benchmark-runtime workflow #1641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @niteshb3495 - before I approve this PR, have you tried to run the benchmark once? Don't have to be a full benchmarking run, can be a minimal example to show it actually works ( = eventually a PR can be created for the file change) |
|
Not recently, but yes, a few months ago, I did check it. |
Co-authored-by: niteshb3495 <niteshb3495@users.noreply.github.com>
Kailai-Wang
reviewed
May 2, 2023
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## dev #1641 +/- ##
==========================================
- Coverage 18.90% 18.86% -0.05%
==========================================
Files 271 271
Lines 13070 13100 +30
==========================================
Hits 2471 2471
- Misses 10599 10629 +30
|
Kailai-Wang
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testing with jumphost as a runner