Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the sidechain metadata and type generation #1675

Merged
merged 6 commits into from
May 10, 2023
Merged

Fix the sidechain metadata and type generation #1675

merged 6 commits into from
May 10, 2023

Conversation

Kailai-Wang
Copy link
Collaborator

resolves #1672

It should give you the real sidechain metadata. The augmented types are re-generated too using "@polkadot/typegen": "^9.14.2".

TODO:

@Kailai-Wang Kailai-Wang requested a review from a team May 10, 2023 13:05
@Kailai-Wang Kailai-Wang self-assigned this May 10, 2023
kziemianek
kziemianek approved these changes May 10, 2023
View reviewed changes
Copy link
Member

@kziemianek kziemianek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I generated those types locally and recieved the same output.

tee-worker/core/rpc-client/src/mock.rs Show resolved Hide resolved
@Kailai-Wang Kailai-Wang merged commit e5de15b into dev May 10, 2023
@Kailai-Wang Kailai-Wang deleted the 1672-sidechain-metadata branch May 10, 2023 17:18
@Kailai-Wang Kailai-Wang mentioned this pull request May 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kziemianek kziemianek kziemianek approved these changes

Assignees

@Kailai-Wang Kailai-Wang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong metadata in tee-worker ts-tests
2 participants
@Kailai-Wang @kziemianek