Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

atomic IMT pallet operations #1737

Merged
merged 3 commits into from
May 27, 2023
Merged

atomic IMT pallet operations #1737

merged 3 commits into from
May 27, 2023

Conversation

kziemianek
Copy link
Member

Merge multiple IMT pallet operations into one

fixes: #1705

@kziemianek kziemianek requested a review from a team May 26, 2023 12:22
@kziemianek
Copy link
Member Author

I checked it locally and multiple calls to pallet in single trusted call might result in inconsistent pallet state because storage transaction is open per pallet call. It's better to avoid such multiple calls whenever possible.

Copy link
Collaborator

@Kailai-Wang Kailai-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@Kailai-Wang Kailai-Wang merged commit 0f0cc31 into dev May 27, 2023
27 checks passed
@Kailai-Wang Kailai-Wang deleted the 1705-remove-challenge-code branch May 27, 2023 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Double-check the atomicity/state mutation of trusted call execution
2 participants