-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hardcode data provider config into prod enclave #2291
hardcode data provider config into prod enclave #2291
Conversation
P-233 Hardcode the data provider URL/constants into prod enclave
As topic - currently these configurations (e.g. "official_twitter_url", achainable endpoint etc) are read from the file. This is risky as the enclave operator could use a wrong config file intentionally or unintentionally, it also means they are free to change the endpoint. Basically we need to:
|
…-into-prod-enclave
In general, the refactor looks good for me. Let's get the CI tests pass.
|
@BillyWooo this PR doesn't affect mock server. Regarding waiting for other PRs im fine with it. We can wait even longer - untill we drop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
I would say so. Thanks |
Will we affect the mock server in the future? |
I think we don't have any plans for it. |
…-into-prod-enclave
…-into-prod-enclave
…-into-prod-enclave
I've made few changes, there very plenty of conflicts and problem with shielding key so I'm requesting a review again 🙃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in general, LGTM. Some points to talk with you privately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve the conflict and get CI jobs pass. Thank you.
…-into-prod-enclave
running-mode
CLI argStfTaskContext
holds reference toShieldingKeyRepository
because shielding key can be changed after mu-ra key provisioning.