Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix - IDH-488 Fix lit staking parse error #2398

Merged
merged 2 commits into from
Jan 10, 2024
Merged

Hotfix - IDH-488 Fix lit staking parse error #2398

merged 2 commits into from
Jan 10, 2024

Conversation

outofxxx
Copy link
Contributor

Filter out web2 identity.

@outofxxx outofxxx requested review from BillyWooo and a team January 10, 2024 06:34
@outofxxx outofxxx changed the title Hotfix - Fix lit staking parse error Hotfix - IDH-488 Fix lit staking parse error Jan 10, 2024
@linear Linear
Copy link

linear bot commented Jan 10, 2024

IDH-488 There's an error when generating LIT staking amount credential

Kailai-Wang
Kailai-Wang reviewed Jan 10, 2024
View reviewed changes
Copy link
Collaborator

@Kailai-Wang Kailai-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Does it happen to other assertion building as well? Shall we have such a filtering in one level higher?

@outofxxx
Copy link
Contributor Author

Thank you!

Does it happen to other assertion building as well? Shall we have such a filtering in one level higher?

No other issues have been found yet, but here I used the identity method to_account_id cause ParseError. Filtering out web2 here can solve the problem.

@Kailai-Wang Kailai-Wang merged commit 68f4237 into dev Jan 10, 2024
31 checks passed
@Kailai-Wang Kailai-Wang deleted the fix-litstaking-parse-error branch January 10, 2024 15:04
outofxxx added a commit that referenced this pull request Jan 11, 2024
@outofxxx
filter out web2 identites (#2398)
e510a5b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kailai-Wang Kailai-Wang Kailai-Wang approved these changes

@BillyWooo BillyWooo Awaiting requested review from BillyWooo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@outofxxx @Kailai-Wang