-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
P-54 Binary search for holding time assertion #2401
Merged
grumpygreenguy
merged 18 commits into
dev
from
p-54-reduce-number-of-requests-in-holder-assertion-building
Jan 26, 2024
Merged
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
4f16439
Binary search for holding time
grumpygreenguy d0b04e9
update tests
grumpygreenguy bcb6c25
add redundant check
grumpygreenguy 4ac47ba
Merge remote-tracking branch 'origin/dev' into p-54-reduce-number-of-…
grumpygreenguy e97d333
fix clipi
grumpygreenguy 0e3d1b6
fix compilation issues
grumpygreenguy 9d32d4f
oops
grumpygreenguy 2e41262
Merge branch 'dev' into p-54-reduce-number-of-requests-in-holder-asse…
grumpygreenguy 3520d7b
Merge branch 'dev' into p-54-reduce-number-of-requests-in-holder-asse…
Kailai-Wang f7f538a
refactoring attempt #3
grumpygreenguy 477be43
try to fix compile error
Kailai-Wang a97b32b
Merge branch 'dev' into p-54-reduce-number-of-requests-in-holder-asse…
outofxxx cf3bb00
retrigger CI
grumpygreenguy 572cb1a
clipy
grumpygreenguy f50de98
more clippy
grumpygreenguy 0990d56
Merge branch 'dev' into p-54-reduce-number-of-requests-in-holder-asse…
grumpygreenguy b99c5ce
more more clippy
grumpygreenguy a9ab3f8
and more
grumpygreenguy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Kailai-Wang for fixing this issue! Still gotta wrap my head around some of the subtleties here, apparently :D
In this case the extra
clone
shouldn't make a huge difference overall, since the cost is in any case dominated by the HTTP requests; in general though it does feel a bit wasteful to have to clone the array each time, only to replace the original anyway after the call toholding_time_search_step
. What would (in theory) have been the better approach here? (Not for this PR to be sure, just as an overall learning)