-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Worker Docker release build without using cache #2423
Conversation
47cfafb
to
c03f8b3
Compare
d83da14
to
4dc71e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
I personally prefer a separate Dockerfile where we don't need everything in local-builder (e.g. sccache) , but I'm fine with this version too :D
@Kailai-Wang , that's valid point and I was thinking of supporting two version of docker file over one with just minor "if" statement, but than I realised that later we may introduce new changes like including |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - a small indention problem
this PR is a follow up for #2313. At regular process using cache for worker build helps us to speed up daily workflow, but in case of preparing releases which happen not so often, we decided to avoid using cache for building docker images