Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Worker Docker release build without using cache #2423

Merged
merged 15 commits into from
Jan 30, 2024

Conversation

Traf333
Copy link
Contributor

@Traf333 Traf333 commented Jan 24, 2024

this PR is a follow up for #2313. At regular process using cache for worker build helps us to speed up daily workflow, but in case of preparing releases which happen not so often, we decided to avoid using cache for building docker images

Copy link

linear bot commented Jan 24, 2024

@Traf333 Traf333 changed the title Worker Docker release build without usingcache Worker Docker release build without using cache Jan 24, 2024
@Traf333 Traf333 force-pushed the p-330-build-the-matching-worker-release-job branch from 47cfafb to c03f8b3 Compare January 24, 2024 18:23
@Traf333 Traf333 force-pushed the p-330-build-the-matching-worker-release-job branch from d83da14 to 4dc71e6 Compare January 26, 2024 13:07
@Traf333 Traf333 self-assigned this Jan 27, 2024
@Traf333 Traf333 marked this pull request as ready for review January 27, 2024 10:47
Copy link
Collaborator

@Kailai-Wang Kailai-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

I personally prefer a separate Dockerfile where we don't need everything in local-builder (e.g. sccache) , but I'm fine with this version too :D

tee-worker/build.Dockerfile Outdated Show resolved Hide resolved
.github/workflows/create-release-draft.yml Outdated Show resolved Hide resolved
.github/workflows/create-release-draft.yml Show resolved Hide resolved
@Traf333
Copy link
Contributor Author

Traf333 commented Jan 29, 2024

I personally prefer a separate Dockerfile where we don't need everything in local-builder (e.g. sccache) , but I'm fine with this version too

@Kailai-Wang , that's valid point and I was thinking of supporting two version of docker file over one with just minor "if" statement, but than I realised that later we may introduce new changes like including extract_identity binary or ts-tests folder to register worker to the docker image, which would require further modification. This thoughts lean me towards having single file for now

Copy link
Collaborator

@Kailai-Wang Kailai-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - a small indention problem

.github/workflows/create-release-draft.yml Outdated Show resolved Hide resolved
@Traf333 Traf333 enabled auto-merge (squash) January 30, 2024 09:22
@Traf333 Traf333 merged commit 3571560 into dev Jan 30, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants