-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: pallet_account_fix #2427
Merged
Merged
feat: pallet_account_fix #2427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kailai-Wang
reviewed
Jan 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned, please:
- bump the litentry runtime version
- adjust the hardcoded weights
…ry-parachain into account-reap-fix
Kailai-Wang
approved these changes
Jan 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug has recently been reported by the community, indicating a potential account reset issue under specific circumstances arising from an inconsistency between Polkadot's pallet balance and Litentry's staking mechanism.
In instances where a user has participated in staking while vesting / engaging in a crowdloan, and subsequently reduces their account balance to less than the equivalent of 0.1 LIT, the account will experience a reset.
It is important to note that triggering this bug does not result in permanent damage, but it does render the user unable to receive tokens through unstaking or staking less (a successful unstake event with unreserve 0 event)
The PR is for providing a temporary pallet with two methods for quick fixing.
One method upgrade_accounts for increasing user account with consumer + 1. (So account can not be reaped)
The other method set_balance for adding user balance (reserve and free) since pallet_balances depreciate the old method. (For recovering user data)
The pallet added is only temporary and should be removed once available.