Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pallet_account_fix #2427

Merged
merged 11 commits into from
Jan 29, 2024
Merged

feat: pallet_account_fix #2427

merged 11 commits into from
Jan 29, 2024

Conversation

wangminqi
Copy link
Member

@wangminqi wangminqi commented Jan 25, 2024

A bug has recently been reported by the community, indicating a potential account reset issue under specific circumstances arising from an inconsistency between Polkadot's pallet balance and Litentry's staking mechanism.

In instances where a user has participated in staking while vesting / engaging in a crowdloan, and subsequently reduces their account balance to less than the equivalent of 0.1 LIT, the account will experience a reset.

It is important to note that triggering this bug does not result in permanent damage, but it does render the user unable to receive tokens through unstaking or staking less (a successful unstake event with unreserve 0 event)

The PR is for providing a temporary pallet with two methods for quick fixing.

One method upgrade_accounts for increasing user account with consumer + 1. (So account can not be reaped)
The other method set_balance for adding user balance (reserve and free) since pallet_balances depreciate the old method. (For recovering user data)

The pallet added is only temporary and should be removed once available.

Copy link
Collaborator

@Kailai-Wang Kailai-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned, please:

  • bump the litentry runtime version
  • adjust the hardcoded weights

Copy link
Collaborator

@Kailai-Wang Kailai-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wangminqi wangminqi merged commit 17ce738 into dev Jan 29, 2024
32 checks passed
@wangminqi wangminqi deleted the account-reap-fix branch January 29, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants