Data providers tests for Achainable, Nodereal, Discord, Litentry, and Twitter #2434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xverin
force-pushed
the
achainable-vc-tests
branch
from
6229603
to
eb1dd48
Compare
0xverin
changed the title
0xverin
force-pushed
the
achainable-vc-tests
branch
from
496fc41
to
85e12c9
Compare
0xverin
requested review from
Traf333,
jonalvarezz,
grumpygreenguy and
zhouhuitian
Traf333
approved these changes
Feb 6, 2024
| "mockWeb3Network": "litentry,polkadot", | ||
| "expectedCredentialValue": false | ||
| } | ||
| ] |
There was a problem hiding this comment.
is there any option that we have a successful result and unsuccessful? Like early bird user and non EB user
There was a problem hiding this comment.
Of course, It depends on the configuration of mockDid; that's the purpose of this PR. You can try it locally.
There was a problem hiding this comment.
You can use this address if you want to have a credential with true value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
this pr:
resolves p-367
resolves p-368
resolves p-369
resolves p-370
Add all vcs request json(If anything is missing, please let me know, and will add it.)
Note:
Since mockDid is a real address, but uncontrollable, it can lead to uncertainty about whether expectedCredentialValue is
trueorfalse. If we want to test, I believe we need to find the address yourself, update it, and then run GHA to check the results.