run stf-task-handler thread only for sidechain
#2445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kziemianek
changed the title
vc-issuance thread only for sidechain
Kailai-Wang
approved these changes
Jan 29, 2024
There was a problem hiding this comment.
TBH run_stf_task_handler does need a sidechain while run_vc_issuance doesn't. It works without sidechain. But I've heard there was some init order problem so we put it into sidechain initialization, which is fine.
One thing to notice is that in bitacross worker (where there's no sidechain) we'll need to have a similar task thread :D
kziemianek
changed the title
vc-issuance thread only for sidechainstf-task-handler thread only for sidechain
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.