Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused log target #2447

Merged
merged 2 commits into from
Jan 30, 2024
Merged

remove unused log target #2447

merged 2 commits into from
Jan 30, 2024

Conversation

BillyWooo
Copy link
Collaborator

as title. a minor PR.

@BillyWooo BillyWooo requested a review from a team January 30, 2024 09:52
@Kailai-Wang
Copy link
Collaborator

Hmm could you please explain the background of this PR a bit?
I saw such log which seemed to be fine:

^[[0m^[[38;5;8m[^[[0m2024-01-30T12:20:06Z ^[[0m^[[32mINFO ^[[0m aura^[[0m^[[38;5;8m]^[[0m Claiming slot (284436201)

Copy link
Member

@kziemianek kziemianek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks fine.

In production build we allow only certain targets to be logged.
Unfortunately, custom targets are not on this list - the list is built based on crates names.
Locally with nonprod build the entries may appear @Kailai-Wang .

see:

builder.filter(None, LevelFilter::Off);
module_names.into_iter().for_each(|module| {
builder.filter(Some(module), LevelFilter::Info);
});

@Kailai-Wang
Copy link
Collaborator

I see, thanks!

@Kailai-Wang Kailai-Wang merged commit 918f879 into dev Jan 30, 2024
33 checks passed
@Kailai-Wang Kailai-Wang deleted the remove-log-target branch January 30, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants