fix: remove network option from nodereal config #2451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…RL config, and always use mainnet for network
BillyWooo
approved these changes
Jan 31, 2024
BillyWooo
deleted the
remove-network-option-from-nodereal-dataprovider
branch
BillyWooo
restored the
remove-network-option-from-nodereal-dataprovider
branch
Kailai-Wang
deleted the
remove-network-option-from-nodereal-dataprovider
branch
Kailai-Wang
restored the
remove-network-option-from-nodereal-dataprovider
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
NODEREAL_API_CHAIN_NETWORK_URL will always use mainnet for network
Labels
Please apply following PR-related labels when appropriate:
C0-breaking: if your change could break the existing client, e.g. API change, critical logic changeC1-noteworthy: if your change is non-breaking, but is still worth noticing for the client, e.g. reference code improvementHow (Optional)
Testing Evidences
Please attach any relevant evidences if applicable