Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ethereum and Bitcoin key repository #2454

Merged
merged 7 commits into from
Feb 1, 2024

Conversation

kziemianek
Copy link
Member

Adds secp256k1 key repositories for managing ethereum and bitcoin keys.
The key is sealed using protected filesystem api and stored on disk so it can be reused on next startup.

@kziemianek kziemianek requested a review from a team January 31, 2024 10:37
Copy link

linear bot commented Jan 31, 2024

Copy link
Collaborator

@BillyWooo BillyWooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@Kailai-Wang Kailai-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! So we are using the same seed for btc and eth keys, aren't we (just to confirm

@kziemianek
Copy link
Member Author

Looks good! So we are using the same seed for btc and eth keys, aren't we (just to confirm

The seed is initialized twice (one per create_secp256k1_repository call) using two different RNG instances.
This results in different keys for ethereum and bitcoin repository.

@Kailai-Wang Kailai-Wang enabled auto-merge (squash) February 1, 2024 12:11
@Kailai-Wang Kailai-Wang merged commit 81e8402 into dev Feb 1, 2024
34 checks passed
@kziemianek kziemianek deleted the p-435-wallets-custodian-inside-tee branch February 3, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants