-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor teerex/sidechain pallet into teebag #2459
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kailai-Wang
requested review from
kziemianek,
BillyWooo,
felixfaisal and
a team
February 1, 2024 23:43
felixfaisal
approved these changes
Feb 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Kailai-Wang ,In terms of the refactor itself, I don't see any concerns, I don't know much about the attestation process, So from my side it looks good.
kziemianek
reviewed
Feb 2, 2024
kziemianek
reviewed
Feb 2, 2024
kziemianek
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR uses a new pallet
teebag
to replace teerex + sidechain pallet.It uses the name
teebag
because enclave is like a teabag and the pallet is used to manage the teabag.Additionally:
skip-ias-verify
and changes it to runtime controlworker_type
to allow multiple worker typesEnclave
structure, the map uses the T::AccountId as the key, because that's (the only identifier?) guaranteed to be different for each worker and has a native parachain connectionsgx-verify
from crate to modSome follow-up TODOs - I'll create issues:
But before I continue I'd like to see reviews about this refactoring