Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support payload digest in trusted verification #2460

Merged
merged 4 commits into from
Feb 2, 2024
Merged

Support payload digest in trusted verification #2460

merged 4 commits into from
Feb 2, 2024

Conversation

Kailai-Wang
Copy link
Collaborator

Context

As topic - verify supports both to make it backwards compatible, will remove the old way once the time is right.

I didn't write extra tests because:

  • our current ts-tests cover the old signing way
  • our sign method in rust covers the new signing way

CI passes => both are tested

@Kailai-Wang Kailai-Wang self-assigned this Feb 2, 2024
@linear Linear
Copy link

linear bot commented Feb 2, 2024

P-476 Use payload hash in TrustedCallSigned

@Kailai-Wang Kailai-Wang requested a review from a team February 2, 2024 12:21
@Kailai-Wang Kailai-Wang enabled auto-merge (squash) February 2, 2024 15:06
@Kailai-Wang Kailai-Wang merged commit 76bdf1f into dev Feb 2, 2024
34 checks passed
@Kailai-Wang Kailai-Wang deleted the p-476-use-payload-hash-in-trustedcallsigned branch February 2, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kziemianek kziemianek kziemianek approved these changes

Assignees

@Kailai-Wang Kailai-Wang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Kailai-Wang @kziemianek