Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

local dev env config #2463

Conversation

kziemianek
Copy link
Member

For dev purposes tee-worker should be integrating with mock services.
Currently if we start local dev env without any config changes ts-test won't pass.

We overlooked this change in one of recent PR.

Copy link
Collaborator

@Kailai-Wang Kailai-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed

cc @BillyWooo in case you see any problem

@Kailai-Wang
Copy link
Collaborator

Btw I notice we have different file structures between bitacross and normal worker: tee-worker/local-setup/.env.dev vs bitacross-worker/.env.dev

@kziemianek
Copy link
Member Author

Yes, I started working on bitacross before #2417 was merged so few changes may be missing.

@Kailai-Wang Kailai-Wang merged commit 7fe4959 into dev Feb 2, 2024
34 checks passed
@Kailai-Wang Kailai-Wang deleted the p-482-tee-workerlocal-setupenvdev-should-point-to-mock-instance branch February 2, 2024 14:37
@BillyWooo
Copy link
Collaborator

Indeed

cc @BillyWooo in case you see any problem

No problem. We discussed together. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants