Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust tee-worker counterpart of pallet-teebag #2469

Merged
merged 20 commits into from
Feb 9, 2024

Conversation

Kailai-Wang
Copy link
Collaborator

Context

Only relevant extrinsics are kept - (so no shield_funds and unshield_funs), enough refactoring.

Please review (particularly) the pallet-teebag refactoring and node-api for pallet-teebag storage API access

It's a preparation of P-487 (actually, some code is already removed to make it compile).

@Kailai-Wang Kailai-Wang self-assigned this Feb 6, 2024
Copy link

linear bot commented Feb 6, 2024

@Kailai-Wang Kailai-Wang added the C0-breaking Breaking change that will cause existing client to break label Feb 6, 2024
@Kailai-Wang
Copy link
Collaborator Author

cc @jonalvarezz it will be a breaking change for client (SDK) as the pallet/extrinsic interface has changed

pallets/teebag/src/lib.rs Outdated Show resolved Hide resolved
pallets/teebag/src/lib.rs Outdated Show resolved Hide resolved
pallets/teebag/src/types.rs Show resolved Hide resolved
tee-worker/service/src/main_impl.rs Outdated Show resolved Hide resolved
tee-worker/enclave-runtime/src/attestation.rs Show resolved Hide resolved
tee-worker/service/src/main_impl.rs Show resolved Hide resolved
tee-worker/service/src/main_impl.rs Show resolved Hide resolved
@Kailai-Wang
Copy link
Collaborator Author

fixes P-10
fixes #1133

@Kailai-Wang Kailai-Wang linked an issue Feb 7, 2024 that may be closed by this pull request
@Kailai-Wang
Copy link
Collaborator Author

The lit-resume-worker test fails at the moment, I created an issue P-501

@jonalvarezz
Copy link
Contributor

cc @jonalvarezz it will be a breaking change for client (SDK) as the pallet/extrinsic interface has changed

Yes, quite a breaking change. We'd need to put IDH under maintenance for a few minutes before releasing it.

Btw, will this be released on the original plan of releasing every 3 weeks? So I can plan the client-sdk update accordingly.

@Kailai-Wang
Copy link
Collaborator Author

cc @jonalvarezz it will be a breaking change for client (SDK) as the pallet/extrinsic interface has changed

Yes, quite a breaking change. We'd need to put IDH under maintenance for a few minutes before releasing it.

Btw, will this be released on the original plan of releasing every 3 weeks? So I can plan the client-sdk update accordingly.

I'd prefer an ad-hoc release if the next regular release is distant. However, the majority of IDHub colleagues is on vacation next week so maybe we can't do it in a hurry anyway :(

@Kailai-Wang
Copy link
Collaborator Author

Well mainly the change from teerex to teebag - and the extrinsic/event names have changed.
It affects the registration process, the enclave registry on parachain as well as the callback events (e.g. the famous teerex.ProcessedParentchainBlock event :D )

@jonalvarezz
Copy link
Contributor

I'd prefer an ad-hoc release if the next regular release is distant. However, the majority of IDHub colleagues is on vacation next week so maybe we can't do it in a hurry anyway :(

We can handle that. It is mostly infrastructure so we can definitely do it on behalf of them.

@jonalvarezz
Copy link
Contributor

e.g. the famous teerex.ProcessedParentchainBlock event :D )

Is that one changing names as well? The monitoring service we have relies on it. It'd need update too then

@Kailai-Wang
Copy link
Collaborator Author

Yes it's now teebag.ParentchainBlockProcessed - we'll add more lifecycle events later

Copy link
Member

@felixfaisal felixfaisal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Tested locally

@kziemianek kziemianek merged commit e97481e into dev Feb 9, 2024
29 of 30 checks passed
@Kailai-Wang Kailai-Wang deleted the p-485-adjust-tee-worker-counterpart-of-pallet-teebag branch February 9, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C0-breaking Breaking change that will cause existing client to break
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review the enclave registration process
4 participants