Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

authorize signing tasks #2483

Merged
merged 4 commits into from
Feb 14, 2024
Merged

authorize signing tasks #2483

merged 4 commits into from
Feb 14, 2024

Conversation

kziemianek
Copy link
Member

  • adds logic for signing tasks authorization

@linear Linear
Copy link

linear bot commented Feb 12, 2024

P-511 Signing tasks authorization

Kailai-Wang
Kailai-Wang approved these changes Feb 13, 2024
View reviewed changes
Copy link
Collaborator

@Kailai-Wang Kailai-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

We might be able to further improve the readability by defining a trait for DirectCall to verify the signer's identity (something like verifyCaller) but it's just nice-to-have

@kziemianek kziemianek enabled auto-merge (squash) February 14, 2024 08:28
@kziemianek kziemianek merged commit 9bc0e7e into dev Feb 14, 2024
31 checks passed
@Kailai-Wang Kailai-Wang deleted the p-511-signing-tasks-authorization branch February 14, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kailai-Wang Kailai-Wang Kailai-Wang approved these changes

@felixfaisal felixfaisal Awaiting requested review from felixfaisal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kziemianek @Kailai-Wang