Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the way we run ts tests #2487

Merged
merged 4 commits into from
Feb 13, 2024
Merged

Conversation

Traf333
Copy link
Contributor

@Traf333 Traf333 commented Feb 13, 2024

Context

This PR tends to simplify running integration tests with one pnpm test command
ref: #2431 (comment)

How (Optional)

with new implementation we just have to know filename or use regexp

// within ./ts-tests/integration-tests
pnpm test your-filename.test.ts

// within ./ts-tests/
pnpm --filter integration-tests run test di_vc.test.ts

In case we want to introduce more integration tests, instead of remembering a package script name we just have to use filename instead

// before
entrypoint: "bash -c '/usr/local/worker-cli/lit_ts_integration_test.sh test-data-provider 2>&1' "

//after
entrypoint: "bash -c '/usr/local/worker-cli/lit_ts_integration_test.sh data-provider.test.ts 2>&1' "

Copy link

linear bot commented Feb 13, 2024

Copy link
Collaborator

@Kailai-Wang Kailai-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An improvement for me :)

Could you please update the README, if any?

Invited others for review, too

@Traf333
Copy link
Contributor Author

Traf333 commented Feb 13, 2024

Could you please update the README, if any?

The tee-worker/ts-tests/README.md was adjusted, or @Kailai-Wang do you mean any other READMEs?

@Traf333 Traf333 merged commit 8df8650 into dev Feb 13, 2024
29 checks passed
@Traf333 Traf333 deleted the p-463-refactor-integration-tests-script branch February 13, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants