feat: P-212 Club3 NFT VC #2492

higherordertech · 2024-02-15T08:06:34Z

Context

1 added new data provider morails (other existing data provider does not support the required evm network)
2 added arbitrum and polygon network
3 added general nft holder VC using this new data provider
4 added Club3 VC
5 migrated existing WeirdoGhostGang VC under it

Labels

Please apply following PR-related labels when appropriate:

C0-breaking: if your change could break the existing client, e.g. API change, critical logic change
C1-noteworthy: if your change is non-breaking, but is still worth noticing for the client, e.g. reference code improvement

How (Optional)

Testing Evidences

Please attach any relevant evidences if applicable

{
   "@context":[
      "https://www.w3.org/2018/credentials/v1",
      "https://w3id.org/security/suites/ed25519-2020/v1"
   ],
   "id":"0xb7d828814aeb7bc9c8fa674370b45a3f38eea1b249f400bb48c71e305a46a4af",
   "type":[
      "VerifiableCredential"
   ],
   "credentialSubject":{
      "id":"did:litentry:substrate:0xd4e35b16ec6b417386b948e7eaf5cc642a243096cecf366e6313689b90969f42",
      "description":"You are a holder of a certain kind of NFT",
      "type":"NFT Holder",
      "assertionText":"NftHolder(Club3Sbt)",
      "assertions":[
         {
            "and":[
               {
                  "src":"$nft",
                  "op":"==",
                  "dst":"Club3 SBT"
               },
               {
                  "or":[
                     {
                        "and":[
                           {
                              "src":"$network",
                              "op":"==",
                              "dst":"bsc"
                           },
                           {
                              "src":"$address",
                              "op":"==",
                              "dst":"0x9f488C0dafb1B3bFeeD3e886e0E6E5f3f4517925"
                           }
                        ]
                     },
                     {
                        "and":[
                           {
                              "src":"$network",
                              "op":"==",
                              "dst":"polygon"
                           },
                           {
                              "src":"$address",
                              "op":"==",
                              "dst":"0xAc2e4e67cffa5E82bfA1e169e5F9aa405114C982"
                           }
                        ]
                     },
                     {
                        "and":[
                           {
                              "src":"$network",
                              "op":"==",
                              "dst":"arbitrum"
                           },
                           {
                              "src":"$address",
                              "op":"==",
                              "dst":"0xcccFF19FB8a4a2A206d07842b8F8c8c0A11904C2"
                           }
                        ]
                     }
                  ]
               }
            ]
         }
      ],
      "values":[
         true
      ],
      "endpoint":"wss://rpc.rococo-parachain.litentry.io"
   },
   "issuer":{
      "id":"did:litentry:substrate:0x304209a0581f23786118458a63f7be3b46554fa59be4a12a194c9f3c6304f191",
      "name":"Litentry TEE Worker",
      "mrenclave":"5tJCvdgWoScE27uQPC5YafWePiR7Qn2V9apJPR44ZfMT"
   },
   "issuanceDate":"2024-02-15T12:00:37.078191645+00:00",
   "parachainBlockNumber":50,
   "sidechainBlockNumber":92,
   "proof":{
      "created":"2024-02-15T12:00:37.079184850+00:00",
      "type":"Ed25519Signature2020",
      "proofPurpose":"assertionMethod",
      "proofValue":"4c2469c052dbb131f5a1bc26cefe72856cb332417beec8b9507dd4c9e714a6937eb362b020018b78de87c8c96b9fc85ff7b75d89d0fe14d4c7d556b9d1814103",
      "verificationMethod":"0x304209a0581f23786118458a63f7be3b46554fa59be4a12a194c9f3c6304f191"
   }
}

linear · 2024-02-15T08:06:36Z

P-212 Implement ERC1155 holder VC

higherordertech · 2024-02-15T08:08:42Z

added new evm network support for polygon and arbitrum, pls see how client side wanted to extend the supported network. @YoshiyukiSakura

felixfaisal

Hey @higherordertech
Not related to the PR directly, But i see these crates assertion-build-v2 and credential-v2,

I may have missed out why we are creating separate crates for different versions?
Do we plan on continuing to iter this way, wherein we have v3 and then v4?
If not are we planning on merging assertion-build-v2 and assertion-build, So what we waiting for in order to merge?

We have existing feature gating and version controlling features in Rust without having to explicitly define v2 crates and so on.

tee-worker/litentry/core/data-providers/src/moralis.rs

higherordertech · 2024-02-15T08:38:15Z

Hey @higherordertech Not related to the PR directly, But i see these crates assertion-build-v2 and credential-v2,

I may have missed out why we are creating separate crates for different versions?

Do we plan on continuing to iter this way, wherein we have v3 and then v4?

If not are we planning on merging assertion-build-v2 and assertion-build, So what we waiting for in order to merge?

We have existing feature gating and version controlling features in Rust without having to explicitly define v2 crates and so on.

The plan is to migrate all v1 credentials under v2 and then v1 can be deprecated and v2 can be renamed to be the only version. Currently they co-exists because the migration work is not prioritised yet (while we are still catching new VC requirement), while at same time some of the new VC can not really be implemented via the v1 structure.

Kailai-Wang

Not much to complain from my side :)
I've been wondering the difference between lc-credential and lc-crediential-v2

Kailai-Wang · 2024-02-15T08:57:00Z

tee-worker/local-setup/.env.dev

@@ -31,6 +31,8 @@ ACHAINABLE_AUTH_KEY=
 ONEBLOCK_NOTION_KEY=
 NODEREAL_API_KEY=
 GENIIDATA_API_KEY=
+GENIIDATA_API_KEY=142cf1b0-1ca7-11ee-bb5e-9d74c2e854ac


We have this key already - see the line above

Kailai-Wang · 2024-02-15T09:04:40Z

tee-worker/litentry/core/data-providers/src/moralis.rs

+		let api_key = data_provider_config.moralis_api_key.clone();
+		let api_retry_delay = data_provider_config.moralis_api_retry_delay;
+		let api_retry_times = data_provider_config.moralis_api_retry_times;
+		let api_url = data_provider_config.moralis_api_url.clone();


It's out of this PR's scope, but sooner or later we'll need a refactoring to have a trait-based impl. The background is I see a lot of duplicate code, we could have something like build_client_with auth or build_client_with retry - or as fn parameters. 🤔

added fail fast boolean option in service layer, and trait in data provider layer now

higherordertech · 2024-02-19T05:57:11Z

With minimum changes, also added RetryableError for client to differentiate retryable error or non retryable error:

>>>command: PlatformUser(
    KaratDaoUser,
)
Trusted call 0x0b19000591014461746150726f76696465724572726f7228426f756e64656456 is TopExecuted([11, 25, 0, 5, 145, 1, 68, 97, 116, 97, 80, 114, 111, 118, 105, 100, 101, 114, 69, 114, 114, 111, 114, 40, 66, 111, 117, 110, 100, 101, 100, 86, 101, 99, 40, 91, 56, 50, 44, 32, 49, 48, 49, 44, 32, 49, 49, 54, 44, 32, 49, 49, 52, 44, 32, 49, 50, 49, 44, 32, 57, 55, 44, 32, 57, 56, 44, 32, 49, 48, 56, 44, 32, 49, 48, 49, 44, 32, 54, 57, 44, 32, 49, 49, 52, 44, 32, 49, 49, 52, 44, 32, 49, 49, 49, 44, 32, 49, 49, 52, 44, 32, 52, 48, 44, 32], false)
Default { msg: "[Error] Error occurred while executing trusted call: RequestVCFailed(PlatformUser(KaratDaoUser), DataProviderError(BoundedVec([68, 97, 116, 97, 80, 114, 111, 118, 105, 100, 101, 114, 69, 114, 114, 111, 114, 40, 66, 111, 117, 110, 100, 101, 100, 86, 101, 99, 40, 91, 56, 50, 44, 32, 49, 48, 49, 44, 32, 49, 49, 54, 44, 32, 49, 49, 52, 44, 32, 49, 50, 49, 44, 32, 57, 55, 44, 32, 57, 56, 44, 32, 49, 48, 56, 44, 32, 49, 48, 49, 44, 32, 54, 57, 44, 32, 49, 49, 52, 44, 32, 49, 49, 52, 44, 32, 49, 49, 49, 44, 32, 49, 49, 52, 44, 32, 52, 48, 44, 32], 100)))" }

RetryableError  BoundedVec converted to string is:
RetryableError("Fail to call rest api within 0 retries")

felixfaisal

LGTM

Kailai-Wang · 2024-02-19T23:24:57Z

Asking for reviews from @BillyWooo @zhouhuitian

…on network, added general nft holder VC using this new data provider, added Club3 VC, migrated existing WeirdoGhostGang VC under it

higherordertech · 2024-02-20T01:10:27Z

Not much to complain from my side :) I've been wondering the difference between lc-credential and lc-crediential-v2

@Kailai-Wang let me take this chance to explain the differences:

lc-credentials-v2 does not depend on lc-data-providers, and doesn't depend on any data provider from the credential level, nor limit how many data provider can be used. e.g. there won't be so called achainable credential or noderal credentail, instead a credential is just a credential decoupled from any (one or many) data providers it would require to use.

while lc-credentials depend on lc-data-providers and has always hard coded the data provider dependency in credential level, and also constraint one credential can only use max one data provider

higherordertech added the C1-noteworthy Non-breaking change but is worth noticing for client label Feb 15, 2024

higherordertech requested review from zhouhuitian and BillyWooo February 15, 2024 08:15

felixfaisal reviewed Feb 15, 2024

View reviewed changes

tee-worker/litentry/core/data-providers/src/moralis.rs Outdated Show resolved Hide resolved

Kailai-Wang reviewed Feb 15, 2024

View reviewed changes

higherordertech force-pushed the P-212 branch from e0e3b45 to aa43143 Compare February 19, 2024 05:43

higherordertech requested review from Kailai-Wang and felixfaisal February 19, 2024 05:58

felixfaisal approved these changes Feb 19, 2024

View reviewed changes

higherordertech enabled auto-merge (squash) February 19, 2024 22:25

higherordertech force-pushed the P-212 branch from e48d982 to 4b9fd13 Compare February 19, 2024 22:25

higherordertech force-pushed the P-212 branch from 4b9fd13 to b19386d Compare February 20, 2024 00:20

higherordertech added 3 commits February 20, 2024 12:08

feat: P-212 added new data provider morails, added arbitrum and polyg…

a7e5d18

…on network, added general nft holder VC using this new data provider, added Club3 VC, migrated existing WeirdoGhostGang VC under it

add fail fast config for retryable api, add RetryableError

f168172

fix build error

993a002

higherordertech force-pushed the P-212 branch from b19386d to 993a002 Compare February 20, 2024 01:09

higherordertech merged commit 4de61c8 into dev Feb 20, 2024
31 checks passed

BillyWooo deleted the P-212 branch February 20, 2024 06:54

jonalvarezz mentioned this pull request Feb 29, 2024

feat: add nft-holder schema litentry/vc-jsonschema#22

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: P-212 Club3 NFT VC #2492

feat: P-212 Club3 NFT VC #2492

higherordertech commented Feb 15, 2024 •

edited

linear bot commented Feb 15, 2024

higherordertech commented Feb 15, 2024

felixfaisal left a comment

higherordertech commented Feb 15, 2024 •

edited

Kailai-Wang left a comment

Kailai-Wang Feb 15, 2024

Kailai-Wang Feb 15, 2024

higherordertech Feb 19, 2024

higherordertech commented Feb 19, 2024 •

edited

felixfaisal left a comment

Kailai-Wang commented Feb 19, 2024

higherordertech commented Feb 20, 2024

feat: P-212 Club3 NFT VC #2492

feat: P-212 Club3 NFT VC #2492

Conversation

higherordertech commented Feb 15, 2024 • edited

Context

Labels

How (Optional)

Testing Evidences

linear bot commented Feb 15, 2024

higherordertech commented Feb 15, 2024

felixfaisal left a comment

Choose a reason for hiding this comment

higherordertech commented Feb 15, 2024 • edited

Kailai-Wang left a comment

Choose a reason for hiding this comment

Kailai-Wang Feb 15, 2024

Choose a reason for hiding this comment

Kailai-Wang Feb 15, 2024

Choose a reason for hiding this comment

higherordertech Feb 19, 2024

Choose a reason for hiding this comment

higherordertech commented Feb 19, 2024 • edited

felixfaisal left a comment

Choose a reason for hiding this comment

Kailai-Wang commented Feb 19, 2024

higherordertech commented Feb 20, 2024

higherordertech commented Feb 15, 2024 •

edited

higherordertech commented Feb 15, 2024 •

edited

higherordertech commented Feb 19, 2024 •

edited