Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check all subcommands / option flags of litentry-worker and litentry-cli #2496

Merged

Conversation

Traf333
Copy link
Contributor

@Traf333 Traf333 commented Feb 16, 2024

Context

This PR is tend to adjust missing or misleading descriptions. In addition it was decided to remove indirect linking identity command due to having direct cli command

Copy link

linear bot commented Feb 16, 2024

@Traf333 Traf333 marked this pull request as draft February 16, 2024 07:43
@Traf333 Traf333 self-assigned this Feb 16, 2024
@Traf333 Traf333 marked this pull request as ready for review February 16, 2024 14:03
tee-worker/service/src/cli.yml Outdated Show resolved Hide resolved
tee-worker/cli/src/base_cli/mod.rs Show resolved Hide resolved
Copy link
Collaborator

@Kailai-Wang Kailai-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I invited @BillyWooo and @zhouhuitian for review too

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to keep the format? It's been changing back and forth .. I know it's probably some automatic formatting from IDE, but still..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

egh, again. Will be more cautious with yml files and will setup proper formating in IDE. Thanks for pointing

Copy link
Collaborator

@BillyWooo BillyWooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good for me.
Just want to confirm, have all subcommands been checked?

@BillyWooo BillyWooo merged commit 8210dd1 into dev Feb 20, 2024
31 of 33 checks passed
@BillyWooo BillyWooo deleted the p-439-check-all-subcommands-option-flags-of-litentry-worker-and branch February 20, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants