-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check all subcommands / option flags of litentry-worker and litentry-cli #2496
Check all subcommands / option flags of litentry-worker and litentry-cli #2496
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I invited @BillyWooo and @zhouhuitian for review too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to keep the format? It's been changing back and forth .. I know it's probably some automatic formatting from IDE, but still..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
egh, again. Will be more cautious with yml files and will setup proper formating in IDE. Thanks for pointing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good for me.
Just want to confirm, have all subcommands been checked?
Context
This PR is tend to adjust missing or misleading descriptions. In addition it was decided to remove indirect linking identity command due to having direct cli command