-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove sidechain feature and sidechain related code from bitacross #2497
Conversation
Thanks! I'm also wondering how hard it would be to add sidechain back (in case we need it someday) 😂 |
That's a good point. As long as bitacross and identity workers are based on the same upstream commit it shouldn't be hard, taking code from upstream shouldn't be hard too. Things might complicate once identity and bitacross workers are based on different upstream commits and we want to 'copy' identity worker sidechain into bitacross. In general it might potentially require work from us to bring this code back, but from the other hand if any further development is planned it might also save time because we don't need to maintain unused code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to merge it once CI passes
Nothing built here, just removal of unused sidechain code from bitacross worker.