Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P-328 Make unconfiguredAssertions pass the test #2508

Merged
merged 19 commits into from
Feb 27, 2024
Merged

P-328 Make unconfiguredAssertions pass the test #2508

merged 19 commits into from
Feb 27, 2024

Conversation

0xverin
Copy link
Contributor

@0xverin 0xverin commented Feb 20, 2024 •
edited

Context

resolves p-328

@linear Linear
Copy link

linear bot commented Feb 20, 2024

P-328 Follow up: Make unconfiguredAssertions pass the test.

@0xverin 0xverin marked this pull request as draft February 20, 2024 14:28
@0xverin 0xverin marked this pull request as ready for review February 26, 2024 09:17
@0xverin 0xverin changed the title P-328 add new basic vc tests P-328 Make unconfiguredAssertions pass the test Feb 26, 2024
Traf333
Traf333 reviewed Feb 27, 2024
View reviewed changes
Copy link
Contributor

@Traf333 Traf333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, but seems mock server doesn't work as expected since tests are failing. Once they are green :shipit:

@0xverin
Copy link
Contributor Author

0xverin commented Feb 27, 2024 •
edited

Overall looks good, but seems mock server doesn't work as expected since tests are failing. Once they are green :shipit:

Unfortunately ci still fails but I can confirm that everything is fine locally. any ideas?
I think I got the reason.

@Kailai-Wang
Copy link
Collaborator

The error says:

NoderealError("Nodereal response error: Server returned non-success status: 400, details: Bad Reques

@0xverin
Copy link
Contributor Author

0xverin commented Feb 27, 2024

The error says:

NoderealError("Nodereal response error: Server returned non-success status: 400, details: Bad Reques

I think I know what the reason is, apikey use defalut value here

@Kailai-Wang Kailai-Wang merged commit 7e8bbe7 into dev Feb 27, 2024
31 checks passed
@Kailai-Wang Kailai-Wang deleted the p-328-add-new-basic-vc-tests branch February 27, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Traf333 Traf333 Traf333 left review comments

@kziemianek kziemianek kziemianek approved these changes

@zhouhuitian zhouhuitian Awaiting requested review from zhouhuitian

@grumpygreenguy grumpygreenguy Awaiting requested review from grumpygreenguy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@0xverin @Kailai-Wang @kziemianek @Traf333