P 491 - url checking #2511
P 491 - url checking #2511
Conversation
| @@ -28,7 +28,7 @@ pub mod files { | |||
|
|
|||
| // used by enclave | |||
| /// Path to the light-client db for the Integritee parentchain. | |||
| pub const LITENTRY_PARENTCHAIN_LIGHT_CLIENT_DB_PATH: &str = "integritee_lcdb"; | |||
There was a problem hiding this comment.
will this require --clean-state for currently deployed bc-worker or some manual work during deployment for renaming dirs?
There was a problem hiding this comment.
If you want to keep history data, just rename the previous folder from integritee_lcdb to litentry_lcdb.
| let http_client = HttpClient::new(DefaultSend {}, true, Some(TIMEOUT), Some(headers), None); | ||
| RestClient::new(http_client, base_url) | ||
| } | ||
|
|
||
| pub fn build_client_with_cert( | ||
| base_url: &str, |
There was a problem hiding this comment.
Can this function accept already parsed url Url instead of str ?
| } | ||
| pub fn set_twitter_official_url(&mut self, v: String) { | ||
| pub fn set_twitter_official_url(&mut self, v: String) -> Result<(), Error> { | ||
| check_url(&v)?; | ||
| debug!("set_twitter_official_url: {:?}", v); | ||
| self.twitter_official_url = v; |
There was a problem hiding this comment.
Have you considered changing twitter_official_url type to Url ?
There was a problem hiding this comment.
Had similar comment above :D
| log::debug!("Initializing data providers config"); | ||
|
|
||
| // default prod config | ||
| let mut config = DataProviderConfig { | ||
| twitter_official_url: "https://api.twitter.com".to_string(), | ||
| twitter_litentry_url: "http://127.0.0.1:9527”".to_string(), | ||
| twitter_litentry_url: "http://127.0.0.1:9527".to_string(), |
There was a problem hiding this comment.
If these URL is going to be used asUrl anyway, can we declare it as Url type?
Same applies to setters
| } | ||
| pub fn set_twitter_official_url(&mut self, v: String) { | ||
| pub fn set_twitter_official_url(&mut self, v: String) -> Result<(), Error> { | ||
| check_url(&v)?; | ||
| debug!("set_twitter_official_url: {:?}", v); | ||
| self.twitter_official_url = v; |
There was a problem hiding this comment.
Had similar comment above :D
build_client, replace withbuild_client_with_cert