Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo add -> aad #2518

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Fix typo add -> aad #2518

merged 1 commit into from
Feb 22, 2024

Conversation

Kailai-Wang
Copy link
Collaborator

Context

A trivial PR thanks to bc colleagues.

Somehow we haven't got any runtime error even though it's correctly written in the definitions:

Maybe it worked because of default values.

@Kailai-Wang Kailai-Wang requested a review from a team February 22, 2024 15:44
@Kailai-Wang Kailai-Wang self-assigned this Feb 22, 2024
Copy link
Contributor

@jonalvarezz jonalvarezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol, I think it works because most likely createType defaults non-specified properties to undefined anyway.

@Kailai-Wang Kailai-Wang enabled auto-merge (squash) February 22, 2024 16:00
@Kailai-Wang Kailai-Wang merged commit e8578bf into dev Feb 22, 2024
31 checks passed
@Kailai-Wang Kailai-Wang deleted the fix-typo branch February 22, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants