Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: P-507 config key renaming and refactor #2519

Merged
merged 1 commit into from
Feb 23, 2024
Merged

fix: P-507 config key renaming and refactor #2519

merged 1 commit into from
Feb 23, 2024

Conversation

higherordertech
Copy link
Contributor

@higherordertech higherordertech commented Feb 23, 2024

rename config name discord_litentry_url to litentry_discord_microservice_url, added prod api endpoint for it, and remove twitter_litentry mock and config

Context

1 rename config name discord_litentry_url to litentry_discord_microservice_url

2 added prod api endpoint for it

3 remove twitter_litentry mock and config

Labels

Please apply following PR-related labels when appropriate:

  • C0-breaking: if your change could break the existing client, e.g. API change, critical logic change
  • C1-noteworthy: if your change is non-breaking, but is still worth noticing for the client, e.g. reference code improvement

How (Optional)

Testing Evidences

Please attach any relevant evidences if applicable

Verified the discord related VC generation working by pointing to https://tee-microservice.litentry.io:9528

{"@context":["https://www.w3.org/2018/credentials/v1","https://w3id.org/security/suites/ed25519-2020/v1"],"id":"0xbcdd3113cb269e701dfd03f5de591e350bdac65236328e266dfa921225da526b","type":["VerifiableCredential"],"credentialSubject":{"id":"did:litentry:substrate:0xd4e35b16ec6b417386b948e7eaf5cc642a243096cecf366e6313689b90969f42","description":"The user is a member of Litentry Discord.\nServer link: https://discord.gg/phBSa3eMX9\nGuild ID: 807161594245152800.","type":"Litentry Discord Member","assertionText":"A2(BoundedVec([50, 49, 51, 49, 50, 51], 64))","assertions":[{"and":[{"src":"$verified_discord_account","op":">","dst":"0"},{"src":"$has_joined","op":"==","dst":"true"},{"src":"$discord_guild_id","op":"==","dst":"213123"}]}],"values":[false],"endpoint":"wss://rpc.rococo-parachain.litentry.io/"},"issuer":{"id":"did:litentry:substrate:0x20fe897dd42b54cdd69096e025611b5394ad00c5e09a698c79dd114967b5b49b","name":"Litentry TEE Worker","mrenclave":"6vNHRBksRNPGHA6R1X3mLT1njbkWVqwhfGFY41n9PCz5"},"issuanceDate":"2024-02-23T05:08:13.494364177+00:00","parachainBlockNumber":96,"sidechainBlockNumber":184,"proof":{"created":"2024-02-23T05:08:13.495422010+00:00","type":"Ed25519Signature2020","proofPurpose":"assertionMethod","proofValue":"c55d448ad3b266e3c232cb8aefb890c7610f10391e14c7678d334388b284c1f6ddfb2aafdb0820558a4d47302263728cc5bd4545765edef45771c78202462908","verificationMethod":"0x20fe897dd42b54cdd69096e025611b5394ad00c5e09a698c79dd114967b5b49b"},"credentialSchema":{"id":"https://raw.githubusercontent.com/litentry/vc-jsonschema/main/dist/schemas/2-litentry-discord-member/1-0-0.json","type":"JsonSchemaValidator2018"}}

Copy link

linear bot commented Feb 23, 2024

Copy link
Collaborator

@Kailai-Wang Kailai-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Mind fixing the PR title? It's truncated (and a bit too long)

btw what about tee-worker/litentry/core/data-providers/src/discord_litentry.rs?
For twitter we are not using mock server anymore? Is it because we don't have such VC in practice?

@higherordertech higherordertech changed the title fix: P-507 rename config name discord_litentry_url to litentry_discor… fix: P-507 config key renaming and refactor Feb 23, 2024
…d_microservice_url, added prod api endpoint for it, and remove twitter_litentry mock and config
@higherordertech
Copy link
Contributor Author

higherordertech commented Feb 23, 2024

btw what about tee-worker/litentry/core/data-providers/src/discord_litentry.rs?

discord_litentry config name is already changed in this PR, and test ok with url https://tee-microservice.litentry.io:9528/

For twitter we are not using mock server anymore? Is it because we don't have such VC in practice?

We still have twitter based VC, e.g. A6, in codebase. But all twitter related VC are using twitter_offical api now, so twitter_litentry mock is no need.

@higherordertech higherordertech enabled auto-merge (squash) February 23, 2024 09:24
@higherordertech higherordertech merged commit 717e39f into dev Feb 23, 2024
31 checks passed
@BillyWooo BillyWooo deleted the P-507 branch February 23, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants