Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate warnings in tests mod #2524

Merged
merged 4 commits into from
Mar 8, 2024
Merged

Eliminate warnings in tests mod #2524

merged 4 commits into from
Mar 8, 2024

Conversation

zhouhuitian
Copy link
Contributor

as topic.

@zhouhuitian zhouhuitian added the D5-testing testing related tasks label Feb 26, 2024
@zhouhuitian zhouhuitian requested a review from a team February 26, 2024 15:20
Kailai-Wang
Kailai-Wang reviewed Feb 26, 2024
View reviewed changes
Copy link
Collaborator

@Kailai-Wang Kailai-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - does it mean the tests are not run in CI?

@BillyWooo
Copy link
Collaborator

Thanks - does it mean the tests are not run in CI?

I think this is mainly building warnings. Because of not used return value.

@BillyWooo BillyWooo enabled auto-merge (squash) March 5, 2024 08:17
@BillyWooo BillyWooo disabled auto-merge March 8, 2024 11:55
@BillyWooo BillyWooo merged commit b1e1165 into dev Mar 8, 2024
31 checks passed
@BillyWooo BillyWooo deleted the fix-warnings-in-tests-mod branch March 8, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kailai-Wang Kailai-Wang Kailai-Wang left review comments

@BillyWooo BillyWooo BillyWooo approved these changes

Assignees
No one assigned
Labels
D5-testing testing related tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zhouhuitian @BillyWooo @Kailai-Wang