-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance local setup/launch with python script #2534
Enhance local setup/launch with python script #2534
Conversation
Cool attempt 👍 , can we keep both? Maybe have a command line option |
@Kailai-Wang by oneliner you want to select specific json config or do you mean to have ability to pass arguments with ports and stuff? Asking because I've noticed that hardcoded json configs don't work stable and some of them already outdated. It sounds reasonable to have |
By the way, if we are sticking to this approach, I would also like to include:
|
"removing worker.json ", what's the replacement? Besides, are we still using python files? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Traf333 , I think I'm a little bit biased, Here's what I think:
- Majority of the changes felt like the same logic in python ported to js. I don't see the benefits of moving from python to a js script. I may have missed the discussion on this.
- No update in Readme, Missing steps of installation such as
yarn install
etc. - I'm of the same opinion, that I generally prefer commands and flags over an interactive script, it's quicker to restart and make changes. So would be great if we can have both.
I agree with this opinion. :p |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Traf333 For revamping the entire PR
I tested the following:
- local-binary
- local-binary-standalone
- local-binary with two workers (WOW!)
It looks good from my side 🙌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I tested:
-
local binary
-
local-binary-standalone
LGTM!
Is the "remote" working mode still valid? |
@BillyWooo yes it works as well, but there are couple of moments we should be aware of.
if the remote mode would gain more popularity, in that case we can introduce extra argument for pointing to remote url |
it seems I was wrong. We still shifting ports if 9944 is busy, :( so for now remote option is unavaliable. I'll prepare fix with adding extra argument for remote url |
Context
This PR introduces next changes:
local-setup
folder to the root folderlaunch.py
--config
option, as hardcoded json files are too specific and some of them don't work as expected